JS: mass add missing quality related tags to relevant queries

Author: Napalys

javascript/ql/src/AngularJS/DependencyMismatch.ql

@@ -7,8 +7,9 @@
  * @problem.severity warning
  * @precision very-high
  * @id js/angular/dependency-injection-mismatch
- * @tags correctness
+ * @tags quality
  *       maintainability
+ *       readability
  *       frameworks/angularjs
  */
 

javascript/ql/src/AngularJS/DuplicateDependency.ql

@@ -5,7 +5,9 @@
  * @problem.severity warning
  * @precision very-high
  * @id js/angular/duplicate-dependency
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       readability
  *       frameworks/angularjs
  */
 

javascript/ql/src/AngularJS/IncompatibleService.ql

@@ -5,7 +5,9 @@
  * @problem.severity error
  * @precision high
  * @id js/angular/incompatible-service
- * @tags correctness
+ * @tags quality
+ *       reliability
+ *       correctness
  *       frameworks/angularjs
  */
 

javascript/ql/src/AngularJS/MissingExplicitInjection.ql

@@ -6,8 +6,9 @@
  * @problem.severity warning
  * @precision high
  * @id js/angular/missing-explicit-injection
- * @tags correctness
- *         maintainability
+ * @tags quality
+ *       reliability
+ *       correctness
  *       frameworks/angularjs
  */
 

javascript/ql/src/AngularJS/RepeatedInjection.ql

@@ -5,7 +5,9 @@
  * @problem.severity warning
  * @precision high
  * @id js/angular/repeated-dependency-injection
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       readability
  *       frameworks/angularjs
  */
 

javascript/ql/src/AngularJS/UseNgSrc.ql

@@ -7,7 +7,9 @@
  * @problem.severity warning
  * @precision very-high
  * @id js/angular/expression-in-url-attribute
- * @tags maintainability
+ * @tags quality
+ *       reliability
+ *       correctness
  *       frameworks/angularjs
  */
 

javascript/ql/src/DOM/DuplicateAttributes.ql

@@ -5,7 +5,8 @@
  * @kind problem
  * @problem.severity warning
  * @id js/duplicate-html-attribute
- * @tags maintainability
+ * @tags quality
+ *       maintainability
  *       readability
  * @precision very-high
  */

javascript/ql/src/DOM/MalformedIdAttribute.ql

@@ -5,7 +5,8 @@
  * @kind problem
  * @problem.severity warning
  * @id js/malformed-html-id
- * @tags maintainability
+ * @tags quality
+ *       reliability
  *       correctness
  *       external/cwe/cwe-758
  * @precision very-high

javascript/ql/src/DOM/PseudoEval.ql

@@ -5,8 +5,10 @@
  * @kind problem
  * @problem.severity recommendation
  * @id js/eval-like-call
- * @tags maintainability
- *       external/cwe/cwe-676
+ * @tags quality
+ *       maintainability
+ *       readability
+ *       external/cwe/cwe-67
  * @precision very-high
  */
 

javascript/ql/src/Declarations/ArgumentsRedefined.ql

@@ -6,8 +6,9 @@
  * @kind problem
  * @problem.severity recommendation
  * @id js/arguments-redefinition
- * @tags efficiency
- *       maintainability
+ * @tags quality
+ *       reliability
+ *       performance
  * @precision very-high
  */
 

javascript/ql/src/Declarations/AssignmentToConst.ql

@@ -5,7 +5,8 @@
  * @kind problem
  * @problem.severity error
  * @id js/assignment-to-constant
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  * @precision very-high
  */

javascript/ql/src/Declarations/ClobberingVarInit.ql

@@ -5,7 +5,8 @@
  * @kind problem
  * @problem.severity error
  * @id js/variable-initialization-conflict
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  *       external/cwe/cwe-563
  * @precision very-high

javascript/ql/src/Declarations/ConflictingFunctions.ql

@@ -6,7 +6,8 @@
  * @kind problem
  * @problem.severity error
  * @id js/function-declaration-conflict
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  *       external/cwe/cwe-563
  * @precision high

javascript/ql/src/Declarations/DeadStoreOfLocal.ql

@@ -5,7 +5,9 @@
  * @kind problem
  * @problem.severity warning
  * @id js/useless-assignment-to-local
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       useless-code
  *       external/cwe/cwe-563
  * @precision very-high
  */

javascript/ql/src/Declarations/DeadStoreOfProperty.ql

@@ -4,7 +4,9 @@
  * @kind problem
  * @problem.severity warning
  * @id js/useless-assignment-to-property
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       useless-code
  * @precision high
  */
 

javascript/ql/src/Declarations/DeclBeforeUse.ql

@@ -4,7 +4,8 @@
  * @kind problem
  * @problem.severity warning
  * @id js/use-before-declaration
- * @tags maintainability
+ * @tags quality
+ *       maintainability
  *       readability
  * @precision very-high
  */

javascript/ql/src/Declarations/DefaultArgumentReferencesNestedFunction.ql

@@ -6,7 +6,8 @@
  * @kind problem
  * @problem.severity error
  * @id js/nested-function-reference-in-default-parameter
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  * @precision very-high
  */

javascript/ql/src/Declarations/DuplicateVarDecl.ql

@@ -5,7 +5,9 @@
  * @kind problem
  * @problem.severity recommendation
  * @id js/duplicate-variable-declaration
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       readability
  * @precision very-high
  */
 

javascript/ql/src/Declarations/IneffectiveParameterType.ql

@@ -5,9 +5,10 @@
  * @problem.severity warning
  * @id js/ineffective-parameter-type
  * @precision high
- * @tags correctness
+ * @tags quality
+ *       reliability
+ *       correctness
  *       typescript
- *       quality
  */
 
 import javascript

javascript/ql/src/Declarations/MissingThisQualifier.ql

@@ -4,8 +4,9 @@
  * @kind problem
  * @problem.severity error
  * @id js/missing-this-qualifier
- * @tags maintainability
- *       correctness
+ * @tags quality
+ *       maintainability
+ *       readability
  *       methods
  * @precision high
  */

javascript/ql/src/Declarations/MissingVarDecl.ql

@@ -5,8 +5,9 @@
  * @kind problem
  * @problem.severity warning
  * @id js/missing-variable-declaration
- * @tags reliability
- *       maintainability
+ * @tags quality
+ *       reliability
+ *       correctness
  * @precision high
  */
 

javascript/ql/src/Declarations/MixedStaticInstanceThisAccess.ql

@@ -4,7 +4,9 @@
  * @kind problem
  * @problem.severity error
  * @id js/mixed-static-instance-this-access
- * @tags correctness
+ * @tags quality
+ *       reliability
+ *       correctness
  *       methods
  * @precision high
  */

javascript/ql/src/Declarations/TemporalDeadZone.ql

@@ -5,8 +5,10 @@
  * @kind problem
  * @problem.severity error
  * @id js/variable-use-in-temporal-dead-zone
- * @tags portability
+ * @tags quality
+ *       reliability
  *       correctness
+ *       portability
  * @precision very-high
  */
 

javascript/ql/src/Declarations/UniqueParameterNames.ql

@@ -5,7 +5,8 @@
  * @kind problem
  * @problem.severity error
  * @id js/duplicate-parameter-name
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  * @precision very-high
  */

javascript/ql/src/Declarations/UniquePropertyNames.ql

@@ -6,7 +6,8 @@
  * @kind problem
  * @problem.severity error
  * @id js/overwritten-property
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  *       external/cwe/cwe-563
  * @precision very-high

javascript/ql/src/Declarations/UnreachableMethodOverloads.ql

@@ -7,7 +7,9 @@
  * @problem.severity warning
  * @id js/unreachable-method-overloads
  * @precision high
- * @tags correctness
+ * @tags quality
+ *       reliability
+ *       correctness
  *       typescript
  */
 

javascript/ql/src/Declarations/UnusedVariable.ql

@@ -5,7 +5,9 @@
  * @kind problem
  * @problem.severity recommendation
  * @id js/unused-local-variable
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       useless-code
  * @precision very-high
  */
 

javascript/ql/src/Expressions/ComparisonWithNaN.ql

@@ -5,7 +5,8 @@
  * @kind problem
  * @problem.severity error
  * @id js/comparison-with-nan
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  *       external/cwe/cwe-570
  *       external/cwe/cwe-571

javascript/ql/src/Expressions/DuplicateCondition.ql

@@ -5,8 +5,9 @@
  * @kind problem
  * @problem.severity warning
  * @id js/duplicate-condition
- * @tags maintainability
- *       correctness
+ * @tags quality
+ *       maintainability
+ *       readability
  *       external/cwe/cwe-561
  * @precision very-high
  */

javascript/ql/src/Expressions/DuplicateProperty.ql

@@ -5,7 +5,9 @@
  * @kind problem
  * @problem.severity warning
  * @id js/duplicate-property
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       readability
  *       external/cwe/cwe-563
  * @precision very-high
  */

javascript/ql/src/Expressions/DuplicateSwitchCase.ql

@@ -5,7 +5,8 @@
  * @kind problem
  * @problem.severity warning
  * @id js/duplicate-switch-case
- * @tags maintainability
+ * @tags quality
+ *       reliability
  *       correctness
  *       external/cwe/cwe-561
  * @precision very-high

javascript/ql/src/Expressions/ExprHasNoEffect.ql

@@ -7,10 +7,9 @@
  * @id js/useless-expression
  * @tags quality
  *       maintainability
- *       correctness
+ *       useless-code
  *       external/cwe/cwe-480
  *       external/cwe/cwe-561
- *       useless-code
  * @precision very-high
  */
 

javascript/ql/src/Expressions/HeterogeneousComparison.ql

@@ -6,7 +6,8 @@
  * @kind problem
  * @problem.severity warning
  * @id js/comparison-between-incompatible-types
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  *       external/cwe/cwe-570
  *       external/cwe/cwe-571

javascript/ql/src/Expressions/ImplicitOperandConversion.ql

@@ -5,8 +5,9 @@
  * @kind problem
  * @problem.severity warning
  * @id js/implicit-operand-conversion
- * @tags reliability
- *       readability
+ * @tags quality
+ *       reliability
+ *       correctness
  *       external/cwe/cwe-704
  * @precision very-high
  */

javascript/ql/src/Expressions/MissingAwait.ql

@@ -4,8 +4,9 @@
  * @kind problem
  * @problem.severity warning
  * @id js/missing-await
- * @tags correctness
- *       quality
+ * @tags quality
+ *       reliability
+ *       correctness
  * @precision high
  */
 

javascript/ql/src/Expressions/MissingDotLengthInComparison.ql

@@ -6,7 +6,9 @@
  * @problem.severity warning
  * @id js/missing-dot-length-in-comparison
  * @precision high
- * @tags correctness
+ * @tags quality
+ *       reliability
+ *       correctness
  */
 
 import javascript