Skip to content

Commit 6223b16

Browse files
committed
Update test fixtures
At the same time, rename some classes in `private.rb` so they don't interact with identically-named modules in `calls.rb`.
1 parent 8df5aaa commit 6223b16

File tree

5 files changed

+67
-47
lines changed

5 files changed

+67
-47
lines changed

ruby/ql/test/library-tests/modules/ancestors.expected

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,12 +49,10 @@ calls.rb:
4949

5050
# 15| M
5151

52-
private.rb:
53-
# 1| C
52+
# 29| C
5453
#-----| super -> Object
5554
#-----| include -> M
5655

57-
calls.rb:
5856
# 51| D
5957
#-----| super -> C
6058

@@ -110,6 +108,13 @@ modules.rb:
110108

111109
# 115| XX
112110

111+
private.rb:
112+
# 1| E
113+
#-----| super -> Object
114+
115+
# 42| F
116+
117+
modules.rb:
113118
# 5| Foo::Bar
114119

115120
# 19| Foo::ClassInFoo

ruby/ql/test/library-tests/modules/methods.expected

Lines changed: 33 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
getMethod
22
| calls.rb:15:1:24:3 | M | instance_m | calls.rb:16:5:16:23 | instance_m |
3+
| calls.rb:29:1:44:3 | C | baz | calls.rb:37:5:43:7 | baz |
34
| calls.rb:51:1:55:3 | D | baz | calls.rb:52:5:54:7 | baz |
45
| calls.rb:77:1:80:3 | Integer | abs | calls.rb:79:5:79:16 | abs |
56
| calls.rb:77:1:80:3 | Integer | bit_length | calls.rb:78:5:78:23 | bit_length |
@@ -17,7 +18,7 @@ getMethod
1718
| calls.rb:97:1:100:3 | Object | new | calls.rb:99:5:99:16 | new |
1819
| calls.rb:97:1:100:3 | Object | optional_arg | calls.rb:62:1:65:3 | optional_arg |
1920
| calls.rb:97:1:100:3 | Object | private_on_main | calls.rb:164:1:165:3 | private_on_main |
20-
| calls.rb:97:1:100:3 | Object | private_on_main | private.rb:21:1:22:3 | private_on_main |
21+
| calls.rb:97:1:100:3 | Object | private_on_main | private.rb:31:1:32:3 | private_on_main |
2122
| calls.rb:102:1:104:3 | Hash | [] | calls.rb:103:5:103:15 | [] |
2223
| calls.rb:106:1:117:3 | Array | [] | calls.rb:107:3:107:13 | [] |
2324
| calls.rb:106:1:117:3 | Array | foreach | calls.rb:110:3:116:5 | foreach |
@@ -35,13 +36,27 @@ getMethod
3536
| modules.rb:5:3:14:5 | Foo::Bar | method_in_foo_bar | modules.rb:9:5:10:7 | method_in_foo_bar |
3637
| modules.rb:37:1:46:3 | Bar | method_a | modules.rb:38:3:39:5 | method_a |
3738
| modules.rb:37:1:46:3 | Bar | method_b | modules.rb:41:3:42:5 | method_b |
38-
| private.rb:1:1:19:3 | C | baz | calls.rb:37:5:43:7 | baz |
39-
| private.rb:1:1:19:3 | C | private2 | private.rb:8:3:9:5 | private2 |
40-
| private.rb:1:1:19:3 | C | private3 | private.rb:14:3:15:5 | private3 |
41-
| private.rb:1:1:19:3 | C | private4 | private.rb:17:3:18:5 | private4 |
42-
| private.rb:1:1:19:3 | C | public | private.rb:5:3:6:5 | public |
39+
| private.rb:1:1:29:3 | E | private2 | private.rb:8:3:9:5 | private2 |
40+
| private.rb:1:1:29:3 | E | private3 | private.rb:14:3:15:5 | private3 |
41+
| private.rb:1:1:29:3 | E | private4 | private.rb:17:3:18:5 | private4 |
42+
| private.rb:1:1:29:3 | E | public | private.rb:5:3:6:5 | public |
43+
| private.rb:42:1:60:3 | F | private2 | private.rb:49:3:50:5 | private2 |
44+
| private.rb:42:1:60:3 | F | private3 | private.rb:55:3:56:5 | private3 |
45+
| private.rb:42:1:60:3 | F | private4 | private.rb:58:3:59:5 | private4 |
46+
| private.rb:42:1:60:3 | F | public | private.rb:46:3:47:5 | public |
4347
lookupMethod
4448
| calls.rb:15:1:24:3 | M | instance_m | calls.rb:16:5:16:23 | instance_m |
49+
| calls.rb:29:1:44:3 | C | baz | calls.rb:37:5:43:7 | baz |
50+
| calls.rb:29:1:44:3 | C | call_block | calls.rb:67:1:69:3 | call_block |
51+
| calls.rb:29:1:44:3 | C | foo | calls.rb:1:1:3:3 | foo |
52+
| calls.rb:29:1:44:3 | C | foo | calls.rb:71:1:75:3 | foo |
53+
| calls.rb:29:1:44:3 | C | funny | calls.rb:119:1:121:3 | funny |
54+
| calls.rb:29:1:44:3 | C | indirect | calls.rb:137:1:139:3 | indirect |
55+
| calls.rb:29:1:44:3 | C | instance_m | calls.rb:16:5:16:23 | instance_m |
56+
| calls.rb:29:1:44:3 | C | new | calls.rb:99:5:99:16 | new |
57+
| calls.rb:29:1:44:3 | C | optional_arg | calls.rb:62:1:65:3 | optional_arg |
58+
| calls.rb:29:1:44:3 | C | private_on_main | calls.rb:164:1:165:3 | private_on_main |
59+
| calls.rb:29:1:44:3 | C | puts | calls.rb:87:5:87:17 | puts |
4560
| calls.rb:51:1:55:3 | D | baz | calls.rb:52:5:54:7 | baz |
4661
| calls.rb:51:1:55:3 | D | call_block | calls.rb:67:1:69:3 | call_block |
4762
| calls.rb:51:1:55:3 | D | foo | calls.rb:1:1:3:3 | foo |
@@ -51,11 +66,7 @@ lookupMethod
5166
| calls.rb:51:1:55:3 | D | instance_m | calls.rb:16:5:16:23 | instance_m |
5267
| calls.rb:51:1:55:3 | D | new | calls.rb:99:5:99:16 | new |
5368
| calls.rb:51:1:55:3 | D | optional_arg | calls.rb:62:1:65:3 | optional_arg |
54-
| calls.rb:51:1:55:3 | D | private2 | private.rb:8:3:9:5 | private2 |
55-
| calls.rb:51:1:55:3 | D | private3 | private.rb:14:3:15:5 | private3 |
56-
| calls.rb:51:1:55:3 | D | private4 | private.rb:17:3:18:5 | private4 |
5769
| calls.rb:51:1:55:3 | D | private_on_main | calls.rb:164:1:165:3 | private_on_main |
58-
| calls.rb:51:1:55:3 | D | public | private.rb:5:3:6:5 | public |
5970
| calls.rb:51:1:55:3 | D | puts | calls.rb:87:5:87:17 | puts |
6071
| calls.rb:77:1:80:3 | Integer | abs | calls.rb:79:5:79:16 | abs |
6172
| calls.rb:77:1:80:3 | Integer | bit_length | calls.rb:78:5:78:23 | bit_length |
@@ -93,7 +104,7 @@ lookupMethod
93104
| calls.rb:97:1:100:3 | Object | new | calls.rb:99:5:99:16 | new |
94105
| calls.rb:97:1:100:3 | Object | optional_arg | calls.rb:62:1:65:3 | optional_arg |
95106
| calls.rb:97:1:100:3 | Object | private_on_main | calls.rb:164:1:165:3 | private_on_main |
96-
| calls.rb:97:1:100:3 | Object | private_on_main | private.rb:21:1:22:3 | private_on_main |
107+
| calls.rb:97:1:100:3 | Object | private_on_main | private.rb:31:1:32:3 | private_on_main |
97108
| calls.rb:97:1:100:3 | Object | puts | calls.rb:87:5:87:17 | puts |
98109
| calls.rb:102:1:104:3 | Hash | [] | calls.rb:103:5:103:15 | [] |
99110
| calls.rb:102:1:104:3 | Hash | call_block | calls.rb:67:1:69:3 | call_block |
@@ -205,19 +216,14 @@ lookupMethod
205216
| modules.rb:112:1:113:3 | YY | puts | calls.rb:87:5:87:17 | puts |
206217
| modules.rb:116:7:117:9 | XX::YY | new | calls.rb:99:5:99:16 | new |
207218
| modules.rb:116:7:117:9 | XX::YY | puts | calls.rb:87:5:87:17 | puts |
208-
| private.rb:1:1:19:3 | C | baz | calls.rb:37:5:43:7 | baz |
209-
| private.rb:1:1:19:3 | C | call_block | calls.rb:67:1:69:3 | call_block |
210-
| private.rb:1:1:19:3 | C | foo | calls.rb:1:1:3:3 | foo |
211-
| private.rb:1:1:19:3 | C | foo | calls.rb:71:1:75:3 | foo |
212-
| private.rb:1:1:19:3 | C | funny | calls.rb:119:1:121:3 | funny |
213-
| private.rb:1:1:19:3 | C | indirect | calls.rb:137:1:139:3 | indirect |
214-
| private.rb:1:1:19:3 | C | instance_m | calls.rb:16:5:16:23 | instance_m |
215-
| private.rb:1:1:19:3 | C | new | calls.rb:99:5:99:16 | new |
216-
| private.rb:1:1:19:3 | C | optional_arg | calls.rb:62:1:65:3 | optional_arg |
217-
| private.rb:1:1:19:3 | C | private2 | private.rb:8:3:9:5 | private2 |
218-
| private.rb:1:1:19:3 | C | private3 | private.rb:14:3:15:5 | private3 |
219-
| private.rb:1:1:19:3 | C | private4 | private.rb:17:3:18:5 | private4 |
220-
| private.rb:1:1:19:3 | C | private_on_main | calls.rb:164:1:165:3 | private_on_main |
221-
| private.rb:1:1:19:3 | C | private_on_main | private.rb:21:1:22:3 | private_on_main |
222-
| private.rb:1:1:19:3 | C | public | private.rb:5:3:6:5 | public |
223-
| private.rb:1:1:19:3 | C | puts | calls.rb:87:5:87:17 | puts |
219+
| private.rb:1:1:29:3 | E | new | calls.rb:99:5:99:16 | new |
220+
| private.rb:1:1:29:3 | E | private2 | private.rb:8:3:9:5 | private2 |
221+
| private.rb:1:1:29:3 | E | private3 | private.rb:14:3:15:5 | private3 |
222+
| private.rb:1:1:29:3 | E | private4 | private.rb:17:3:18:5 | private4 |
223+
| private.rb:1:1:29:3 | E | private_on_main | private.rb:31:1:32:3 | private_on_main |
224+
| private.rb:1:1:29:3 | E | public | private.rb:5:3:6:5 | public |
225+
| private.rb:1:1:29:3 | E | puts | calls.rb:87:5:87:17 | puts |
226+
| private.rb:42:1:60:3 | F | private2 | private.rb:49:3:50:5 | private2 |
227+
| private.rb:42:1:60:3 | F | private3 | private.rb:55:3:56:5 | private3 |
228+
| private.rb:42:1:60:3 | F | private4 | private.rb:58:3:59:5 | private4 |
229+
| private.rb:42:1:60:3 | F | public | private.rb:46:3:47:5 | public |

ruby/ql/test/library-tests/modules/modules.expected

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
getModule
22
| calls.rb:15:1:24:3 | M |
3+
| calls.rb:29:1:44:3 | C |
34
| calls.rb:51:1:55:3 | D |
45
| calls.rb:77:1:80:3 | Integer |
56
| calls.rb:82:1:84:3 | String |
@@ -55,9 +56,11 @@ getModule
5556
| modules.rb:115:1:118:3 | XX |
5657
| modules.rb:116:7:117:9 | XX::YY |
5758
| modules.rb:120:1:121:3 | Test::Foo1::Bar::Baz |
58-
| private.rb:1:1:19:3 | C |
59+
| private.rb:1:1:29:3 | E |
60+
| private.rb:42:1:60:3 | F |
5961
getADeclaration
6062
| calls.rb:15:1:24:3 | M | calls.rb:15:1:24:3 | M |
63+
| calls.rb:29:1:44:3 | C | calls.rb:29:1:44:3 | C |
6164
| calls.rb:51:1:55:3 | D | calls.rb:51:1:55:3 | D |
6265
| calls.rb:77:1:80:3 | Integer | calls.rb:77:1:80:3 | Integer |
6366
| calls.rb:82:1:84:3 | String | calls.rb:82:1:84:3 | String |
@@ -67,7 +70,7 @@ getADeclaration
6770
| calls.rb:97:1:100:3 | Object | calls.rb:97:1:100:3 | Object |
6871
| calls.rb:97:1:100:3 | Object | hello.rb:1:1:22:3 | hello.rb |
6972
| calls.rb:97:1:100:3 | Object | modules.rb:1:1:122:1 | modules.rb |
70-
| calls.rb:97:1:100:3 | Object | private.rb:1:1:30:15 | private.rb |
73+
| calls.rb:97:1:100:3 | Object | private.rb:1:1:60:3 | private.rb |
7174
| calls.rb:102:1:104:3 | Hash | calls.rb:102:1:104:3 | Hash |
7275
| calls.rb:106:1:117:3 | Array | calls.rb:106:1:117:3 | Array |
7376
| calls.rb:144:1:148:3 | S | calls.rb:144:1:148:3 | S |
@@ -109,10 +112,11 @@ getADeclaration
109112
| modules.rb:115:1:118:3 | XX | modules.rb:115:1:118:3 | XX |
110113
| modules.rb:116:7:117:9 | XX::YY | modules.rb:116:7:117:9 | YY |
111114
| modules.rb:120:1:121:3 | Test::Foo1::Bar::Baz | modules.rb:120:1:121:3 | Baz |
112-
| private.rb:1:1:19:3 | C | calls.rb:29:1:44:3 | C |
113-
| private.rb:1:1:19:3 | C | private.rb:1:1:19:3 | C |
115+
| private.rb:1:1:29:3 | E | private.rb:1:1:29:3 | E |
116+
| private.rb:42:1:60:3 | F | private.rb:42:1:60:3 | F |
114117
getSuperClass
115-
| calls.rb:51:1:55:3 | D | private.rb:1:1:19:3 | C |
118+
| calls.rb:29:1:44:3 | C | calls.rb:97:1:100:3 | Object |
119+
| calls.rb:51:1:55:3 | D | calls.rb:29:1:44:3 | C |
116120
| calls.rb:77:1:80:3 | Integer | file://:0:0:0:0 | Numeric |
117121
| calls.rb:82:1:84:3 | String | calls.rb:97:1:100:3 | Object |
118122
| calls.rb:90:1:95:3 | Module | calls.rb:97:1:100:3 | Object |
@@ -141,12 +145,12 @@ getSuperClass
141145
| modules.rb:72:5:73:7 | Test::Foo2::Foo2::Bar | calls.rb:97:1:100:3 | Object |
142146
| modules.rb:112:1:113:3 | YY | calls.rb:97:1:100:3 | Object |
143147
| modules.rb:116:7:117:9 | XX::YY | modules.rb:112:1:113:3 | YY |
144-
| private.rb:1:1:19:3 | C | calls.rb:97:1:100:3 | Object |
148+
| private.rb:1:1:29:3 | E | calls.rb:97:1:100:3 | Object |
145149
getAPrependedModule
146150
| modules.rb:101:1:105:3 | PrependTest | modules.rb:63:1:81:3 | Test |
147151
getAnIncludedModule
152+
| calls.rb:29:1:44:3 | C | calls.rb:15:1:24:3 | M |
148153
| calls.rb:97:1:100:3 | Object | calls.rb:86:1:88:3 | Kernel |
149154
| hello.rb:11:1:16:3 | Greeting | hello.rb:1:1:8:3 | EnglishWords |
150155
| modules.rb:88:1:93:3 | IncludeTest | modules.rb:63:1:81:3 | Test |
151156
| modules.rb:95:1:99:3 | IncludeTest2 | modules.rb:63:1:81:3 | Test |
152-
| private.rb:1:1:19:3 | C | calls.rb:15:1:24:3 | M |

ruby/ql/test/library-tests/modules/private.rb

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
class C
1+
class E
22
private def private1
33
end
44

@@ -31,15 +31,15 @@ def self.private6
3131
def private_on_main
3232
end
3333

34-
C.new.private1
35-
C.new.private2
36-
C.new.private3
37-
C.new.private4
38-
C.new.public
34+
E.new.private1
35+
E.new.private2
36+
E.new.private3
37+
E.new.private4
38+
E.new.public
3939

4040
private_on_main
4141

42-
module D
42+
module F
4343
private def private1
4444
end
4545

ruby/ql/test/library-tests/modules/superclasses.expected

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,9 @@ calls.rb:
4848

4949
# 15| M
5050

51-
private.rb:
52-
# 1| C
51+
# 29| C
5352
#-----| -> Object
5453

55-
calls.rb:
5654
# 51| D
5755
#-----| -> C
5856

@@ -104,6 +102,13 @@ modules.rb:
104102

105103
# 115| XX
106104

105+
private.rb:
106+
# 1| E
107+
#-----| -> Object
108+
109+
# 42| F
110+
111+
modules.rb:
107112
# 5| Foo::Bar
108113

109114
# 19| Foo::ClassInFoo

0 commit comments

Comments
 (0)