C#: Sync.

aschackmull · aschackmull · commit 5b21188e0df3 · 2025-05-23T14:17:21.000+02:00
diff --git a/csharp/ql/lib/semmle/code/csharp/dataflow/ModulusAnalysis.qll b/csharp/ql/lib/semmle/code/csharp/dataflow/ModulusAnalysis.qll
@@ -17,7 +17,7 @@ private predicate valueFlowStepSsa(SsaVariable v, SsaReadPosition pos, Expr e, i
   exists(Guard guard, boolean testIsTrue |
     pos.hasReadOfVar(v) and
     guard = eqFlowCond(v, e, delta, true, testIsTrue) and
-    guardDirectlyControlsSsaRead(guard, pos, testIsTrue)
+    guardControlsSsaRead(guard, pos, testIsTrue)
   )
 }
 
diff --git a/csharp/ql/lib/semmle/code/csharp/dataflow/internal/rangeanalysis/ModulusAnalysisSpecific.qll b/csharp/ql/lib/semmle/code/csharp/dataflow/internal/rangeanalysis/ModulusAnalysisSpecific.qll
@@ -32,8 +32,6 @@ module Private {
 
   class LeftShiftExpr = RU::ExprNode::LeftShiftExpr;
 
-  predicate guardDirectlyControlsSsaRead = RU::guardControlsSsaRead/3;
-
   predicate guardControlsSsaRead = RU::guardControlsSsaRead/3;
 
   predicate valueFlowStep = RU::valueFlowStep/3;

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ private predicate valueFlowStepSsa(SsaVariable v, SsaReadPosition pos, Expr e, i`
`17`	`17`	`exists(Guard guard, boolean testIsTrue \|`
`18`	`18`	`pos.hasReadOfVar(v) and`
`19`	`19`	`guard = eqFlowCond(v, e, delta, true, testIsTrue) and`
`20`		`- guardDirectlyControlsSsaRead(guard, pos, testIsTrue)`
	`20`	`+ guardControlsSsaRead(guard, pos, testIsTrue)`
`21`	`21`	`)`
`22`	`22`	`}`
`23`	`23`