Python: more CaptureNode exclusion

yoff · yoff · commit 544ae5e22cf2 · 2023-12-04T16:43:45.000+01:00
diff --git a/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowImplConsistency.qll b/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowImplConsistency.qll
@@ -49,6 +49,9 @@ private module Input implements InputSig<PythonDataFlow> {
       // In that case, there is no associated DataFlowCallable.
       not exists(func.getDefinition())
     )
+    or
+    // We do not have classes as `DataFlowCallable`s.
+    n.(CaptureNode).getSynthesizedCaptureNode().getEnclosingCallable() instanceof Class
   }
 
   predicate uniqueCallEnclosingCallableExclude(DataFlowCall call) {

Original file line number	Diff line number	Diff line change
`@@ -49,6 +49,9 @@ private module Input implements InputSig<PythonDataFlow> {`
`49`	`49`	`// In that case, there is no associated DataFlowCallable.`
`50`	`50`	`not exists(func.getDefinition())`
`51`	`51`	`)`
	`52`	`+ or`
	`53`	+ // We do not have classes as `DataFlowCallable`s.
	`54`	`+ n.(CaptureNode).getSynthesizedCaptureNode().getEnclosingCallable() instanceof Class`
`52`	`55`	`}`
`53`	`56`
`54`	`57`	`predicate uniqueCallEnclosingCallableExclude(DataFlowCall call) {`