Skip to content

Commit 17cd58b

Browse files
authored
Merge pull request #19793 from michaelnebel/ruby/qualitytags
Ruby: Update quality tags.
2 parents 781f788 + 08d28a5 commit 17cd58b

File tree

3 files changed

+11
-4
lines changed

3 files changed

+11
-4
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
category: queryMetadata
3+
---
4+
* Update query metadata tags for `rb/database-query-in-loop` and `rb/useless-assignment-to-local` to align with the established
5+
[Query file metadata and alert message style guide](https://github.com/github/codeql/blob/main/docs/query-metadata-style-guide.md#quality-query-sub-category-tags).

ruby/ql/src/queries/performance/DatabaseQueryInLoop.ql

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,9 @@
55
* @problem.severity info
66
* @precision high
77
* @id rb/database-query-in-loop
8-
* @tags performance
9-
* quality
8+
* @tags quality
9+
* reliability
10+
* performance
1011
*/
1112

1213
import ruby

ruby/ql/src/queries/variables/DeadStoreOfLocal.ql

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,9 @@
55
* @kind problem
66
* @problem.severity warning
77
* @id rb/useless-assignment-to-local
8-
* @tags maintainability
9-
* quality
8+
* @tags quality
9+
* maintainability
10+
* useless-code
1011
* external/cwe/cwe-563
1112
* @precision high
1213
*/

0 commit comments

Comments
 (0)