Merge pull request #5380 from github/criemen/clang-cl

MathiasVP · web-flow · commit 0edae894250d · 2021-03-11T13:56:25.000+01:00
C++: Add clang-cl.exe to `compiledAsMicrosoft()`.
diff --git a/cpp/ql/src/semmle/code/cpp/File.qll b/cpp/ql/src/semmle/code/cpp/File.qll
@@ -276,7 +276,10 @@ class File extends Container, @file {
       c.getAFileCompiled() = this and
       (
         c.getAnArgument() = "--microsoft" or
-        c.getAnArgument().toLowerCase().replaceAll("\\", "/").matches("%/cl.exe")
+        c.getAnArgument()
+            .toLowerCase()
+            .replaceAll("\\", "/")
+            .matches(["%/cl.exe", "%/clang-cl.exe"])
       )
     )
     or

Original file line number	Diff line number	Diff line change
`@@ -276,7 +276,10 @@ class File extends Container, @file {`
`276`	`276`	`c.getAFileCompiled() = this and`
`277`	`277`	`(`
`278`	`278`	`c.getAnArgument() = "--microsoft" or`
`279`		`- c.getAnArgument().toLowerCase().replaceAll("\\", "/").matches("%/cl.exe")`
	`279`	`+ c.getAnArgument()`
	`280`	`+ .toLowerCase()`
	`281`	`+ .replaceAll("\\", "/")`
	`282`	`+ .matches(["%/cl.exe", "%/clang-cl.exe"])`
`280`	`283`	`)`
`281`	`284`	`)`
`282`	`285`	`or`