Declarations5: address review comments

Author: knewbury01

c/misra/src/rules/RULE-8-5/ExternalObjectOrFunctionNotDeclaredInOneFile.ql

@@ -32,12 +32,7 @@ where
     kind = "variable"
   ) and
   // Apply an ordering based on location to enforce that (de1, de2) = (de2, de1) and we only report (de1, de2).
-  (
-    de.getFile().getAbsolutePath() < otherDeclaration.getFile().getAbsolutePath()
-    or
-    de.getFile().getAbsolutePath() = otherDeclaration.getFile().getAbsolutePath() and
-    de.getLocation().getStartLine() < otherDeclaration.getLocation().getStartLine()
-  )
+  de.getFile().getAbsolutePath() < otherDeclaration.getFile().getAbsolutePath()
 select de,
   "The " + kind + " declaration " + de.getName() +
     " is declared in multiple files and has an additional $@.", otherDeclaration, "declaration"

c/misra/src/rules/RULE-8-8/MissingStaticSpecifierObjectRedeclarationC.ql

@@ -18,10 +18,10 @@ from VariableDeclarationEntry redeclaration, VariableDeclarationEntry de
 where
   not isExcluded(redeclaration,
     Declarations5Package::missingStaticSpecifierObjectRedeclarationCQuery()) and
+  //following implies de != redeclaration
   de.hasSpecifier("static") and
-  de.getDeclaration().isTopLevel() and
-  redeclaration.getDeclaration() = de.getDeclaration() and
   not redeclaration.hasSpecifier("static") and
-  de != redeclaration
+  de.getDeclaration().isTopLevel() and
+  redeclaration.getDeclaration() = de.getDeclaration()
 select redeclaration, "The redeclaration of $@ with internal linkage misses the static specifier.",
   de, de.getName()

c/misra/test/rules/RULE-5-2/test.c

@@ -23,4 +23,25 @@ void f() {
 static int
     iltiqzxgfqsgigwfuyntzghvzltueatcxqnqofnnvjy_C; // COMPLIANT length <63
 static int
-    iltiqzxgfqsgigwfuyntzghvzltueatcxqnqofnnvjy_D; // COMPLIANT length <63
+    iltiqzxgfqsgigwfuyntzghvzltueatcxqnqofnnvjy_D; // COMPLIANT length <63
+
+#define iltiqzxgfqsgigwfuyntzghvzltueatcxqnqofnnvjyszmcsylyohvqaosjbqyyA // COMPLIANT
+                                                                         // -
+                                                                         // this
+                                                                         // rule
+                                                                         // does
+                                                                         // not
+                                                                         // consider
+                                                                         // macros
+extern int
+    iltiqzxgfqsgigwfuyntzghvzltueatcxqnqofnnvjyszmcsylyohvqaosjbqyyA; // COMPLIANT
+                                                                      // - this
+                                                                      // rule
+                                                                      // does
+                                                                      // not
+                                                                      // consider
+                                                                      // when
+                                                                      // both
+                                                                      // identifiers
+                                                                      // are
+                                                                      // external

cpp/common/src/codingstandards/cpp/rules/missingstaticspecifierfunctionredeclarationshared/MissingStaticSpecifierFunctionRedeclarationShared.qll

@@ -1,5 +1,5 @@
 /**
- * Provides a library which includes a `problems` predicate for reporting....
+ * Provides a library which includes a `problems` predicate for reporting missing static specifiers for redeclarations of functions with internal linkage.
  */
 
 import cpp

cpp/common/src/codingstandards/cpp/rules/unnecessaryexposedidentifierdeclarationshared/UnnecessaryExposedIdentifierDeclarationShared.qll

@@ -1,5 +1,5 @@
 /**
- * Provides a library which includes a `problems` predicate for reporting....
+ * Provides a library which includes a `problems` predicate for reporting unnecessarily exposed identifiers due to too broad of a scope.
  */
 
 import cpp