Merge branch 'github:main' into Contracts5

Author: mbaluda

.github/pull_request_template.md

@@ -32,6 +32,12 @@ _**Author:**_ Is a change note required?
   - [ ] Yes
   - [ ] No
 
+🚨🚨🚨
+_**Reviewer:**_ Confirm that format of *shared* queries (not the .qll file, the
+.ql file that imports it) is valid by running them within VS Code. 
+  - [ ] Confirmed
+
+
 _**Reviewer:**_ Confirm that either a change note is not required or the change note is required and has been added.
   - [ ] Confirmed
 

.vscode/tasks.json

@@ -206,6 +206,8 @@
                 "Declarations",
                 "Declarations1",
                 "Declarations2",
+                "Declarations3",
+                "Declarations4",
                 "Exceptions1",
                 "Exceptions2",
                 "Expressions",

c/common/test/rules/identifierwithexternallinkageonedefinitionshared/IdentifierWithExternalLinkageOneDefinitionShared.expected

@@ -0,0 +1,2 @@
+| test.c:1:5:1:6 | definition of g1 | The identifier g1 has external linkage and is redefined $@. | test1.c:1:5:1:6 | definition of g1 | here |
+| test.c:6:6:6:7 | definition of f2 | The identifier f2 has external linkage and is redefined $@. | test1.c:6:6:6:7 | definition of f2 | here |

c/common/test/rules/identifierwithexternallinkageonedefinitionshared/IdentifierWithExternalLinkageOneDefinitionShared.ql

@@ -0,0 +1,2 @@
+// GENERATED FILE - DO NOT MODIFY
+import codingstandards.cpp.rules.identifierwithexternallinkageonedefinitionshared.IdentifierWithExternalLinkageOneDefinitionShared

c/common/test/rules/identifierwithexternallinkageonedefinitionshared/test.c

@@ -0,0 +1,6 @@
+int g1 = 1;        // NON_COMPLIANT
+static int g2 = 1; // COMPLIANT; internal linkage
+
+inline void f1() {} // COMPLIANT; inline functions are an exception
+
+void f2() {} // NON_COMPLIANT

c/common/test/rules/identifierwithexternallinkageonedefinitionshared/test1.c

@@ -0,0 +1,6 @@
+int g1 = 0;        // NON_COMPLIANT
+static int g2 = 1; // COMPLIANT; internal linkage
+
+inline void f1() {} // COMPLIANT; inline functions are an exception
+
+void f2() {} // NON_COMPLIANT

c/misra/src/rules/RULE-5-5/IdentifiersNotDistinctFromMacroNames.ql

@@ -14,7 +14,7 @@
 
 import cpp
 import codingstandards.c.misra
-import codingstandards.c.Identifiers
+import codingstandards.cpp.Identifiers
 
 from Macro m, InterestingIdentifiers i, string mName, string iName
 where

c/misra/src/rules/RULE-5-6/TypedefNameNotUnique.ql

@@ -14,7 +14,7 @@
 
 import cpp
 import codingstandards.c.misra
-import codingstandards.c.Identifiers
+import codingstandards.cpp.Identifiers
 
 from TypedefType t, InterestingIdentifiers d
 where

c/misra/src/rules/RULE-5-7/TagNameNotUnique.ql

@@ -14,7 +14,7 @@
 
 import cpp
 import codingstandards.c.misra
-import codingstandards.c.Identifiers
+import codingstandards.cpp.Identifiers
 
 from Struct s, InterestingIdentifiers s2
 where

c/misra/src/rules/RULE-8-2/FunctionTypesNotInPrototypeForm.ql

@@ -0,0 +1,58 @@
+/**
+ * @id c/misra/function-types-not-in-prototype-form
+ * @name RULE-8-2: Function types shall be in prototype form with named parameters
+ * @description Omission of parameter types or names prevents the compiler from doing type checking
+ *              when those functions are used and therefore may result in undefined behaviour.
+ * @kind problem
+ * @precision medium
+ * @problem.severity error
+ * @tags external/misra/id/rule-8-2
+ *       correctness
+ *       external/misra/obligation/required
+ */
+
+import cpp
+import codingstandards.c.misra
+import codingstandards.cpp.Identifiers
+
+/**
+ * `Parameter`s without names
+ */
+class UnnamedParameter extends Parameter {
+  UnnamedParameter() { not this.isNamed() }
+}
+
+/*
+ * This is a copy of the private `hasZeroParamDecl` predicate from the standard set of
+ * queries as of the `codeql-cli/2.11.2` tag in `github/codeql`.
+ */
+
+predicate hasZeroParamDecl(Function f) {
+  exists(FunctionDeclarationEntry fde | fde = f.getADeclarationEntry() |
+    not fde.isImplicit() and
+    not fde.hasVoidParamList() and
+    fde.getNumberOfParameters() = 0 and
+    not fde.isDefinition()
+  )
+}
+
+from Function f, string msg
+where
+  not isExcluded(f, Declarations4Package::functionTypesNotInPrototypeFormQuery()) and
+  f instanceof InterestingIdentifiers and
+  (
+    f.getAParameter() instanceof UnnamedParameter and
+    msg = "Function " + f + " declares parameter that is unnamed."
+    or
+    hasZeroParamDecl(f) and
+    msg = "Function " + f + " does not specifiy void for no parameters present."
+    or
+    //parameters declared in declaration list (not in function signature)
+    //have placeholder file location associated only
+    exists(Parameter p |
+      p.getFunction() = f and
+      not p.getFile() = f.getFile() and
+      msg = "Function " + f + " declares parameter in unsupported declaration list."
+    )
+  )
+select f, msg