Skip to content

Commit 81969d7

Browse files
committed
Prototyping adding quality queries when running queries
1 parent 2c76207 commit 81969d7

File tree

6 files changed

+26
-17
lines changed

6 files changed

+26
-17
lines changed

lib/analyze.js

Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/analyze.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/codeql.js

Lines changed: 3 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/codeql.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/analyze.ts

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -624,6 +624,17 @@ export async function runQueries(
624624
try {
625625
const sarifFile = path.join(sarifFolder, `${language}.sarif`);
626626

627+
if (config.augmentationProperties.qualityQueriesInput !== undefined) {
628+
queryFlags.unshift(`path:${config.tempDir}/config-queries.qls`);
629+
630+
for (const qualityQuery of config.augmentationProperties
631+
.qualityQueriesInput) {
632+
queryFlags.unshift(
633+
resolveQuerySuiteAlias(language, qualityQuery.uses),
634+
);
635+
}
636+
}
637+
627638
// The work needed to generate the query suites
628639
// is done in the CLI. We just need to make a single
629640
// call to run all the queries for each language and

src/codeql.ts

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1219,20 +1219,13 @@ async function generateCodeScanningConfig(
12191219
const augmentedConfig = cloneObject(config.originalUserInput);
12201220

12211221
// Inject the queries from the input
1222-
if (
1223-
config.augmentationProperties.queriesInput ||
1224-
config.augmentationProperties.qualityQueriesInput
1225-
) {
1226-
const queryInputs = (
1227-
config.augmentationProperties.queriesInput || []
1228-
).concat(config.augmentationProperties.qualityQueriesInput || []);
1229-
1222+
if (config.augmentationProperties.queriesInput) {
12301223
if (config.augmentationProperties.queriesInputCombines) {
12311224
augmentedConfig.queries = (augmentedConfig.queries || []).concat(
1232-
queryInputs,
1225+
config.augmentationProperties.queriesInput,
12331226
);
12341227
} else {
1235-
augmentedConfig.queries = queryInputs;
1228+
augmentedConfig.queries = config.augmentationProperties.queriesInput;
12361229
}
12371230
}
12381231
if (augmentedConfig.queries?.length === 0) {

0 commit comments

Comments
 (0)