Skip to content
This repository was archived by the owner on Sep 2, 2023. It is now read-only.

Conversation

@radcortez
Copy link
Contributor

The current JaxrsReader doesn't support all things (for instance @apimodel is not supported), so definitions may generate incomplete.

Swagger JAX-RS library (included in the project) already packs a reader to support out of the box pretty much everything that you can annotate with the Swagger annotations, JAX-RS annotations and Bean Validation annotations.

For now this is added as a different Reader, so you will need to use a custom reader in your build to use it. In the future we may consider to drop the current JaxrsReader and replace it with the Swagger one.

@radcortez
Copy link
Contributor Author

This depends on #140 .

@gigaSproule
Copy link
Owner

gigaSproule commented May 5, 2019

I really appreciate your contribution, so first of all thank you.

Is it not worth replacing it now?

I don't mind doing it, but I'd rather the change be accredited to the person who put the effort into fixing it.

@radcortez
Copy link
Contributor Author

Thanks! Sure, I'll have a look.

@gigaSproule
Copy link
Owner

Hey, have you had a chance to look at replacing? Just thinking of doing a release soon.

@radcortez
Copy link
Contributor Author

I've been focusing on other stuff. Let me see if I can free up some cycles to move forward with this. I don't remember exactly, but I think I've did a quick test when I was working on it and the output was not exactly the same (current JaxRS Reader vs Swagger JaxRS Reader).

Do we want to break it?

@gigaSproule
Copy link
Owner

It's fine for the output to be different, assuming that it actually produces the correct output. I'd rather have a fully working implementation. I'm unaware of any reason why someone would care that the output is marginally different, if it is functionally correct.

@radcortez
Copy link
Contributor Author

Cool. I'll see if I can spare som free cycles to move forward. Cheers.

@gigaSproule gigaSproule force-pushed the master branch 3 times, most recently from 765f1d7 to 8170522 Compare July 28, 2020 22:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants