Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a GitHub action to check for modifications to generated files #183

Closed
BrandonRomano opened this issue Dec 27, 2024 · 1 comment
Closed

Create a GitHub action to check for modifications to generated files #183

BrandonRomano opened this issue Dec 27, 2024 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@BrandonRomano
Copy link
Member

We have some generated files which are actually generated from some upstream comments in the Ghostty repo.

We aught to add in a GitHub workflow which identifies a change and drops a warning comment for contributors. The PR shouldn't be outright rejected (because it might be a PR which comes from generated code being updated!).

...Perhaps something else to make it more clear to authors as to not update those files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BrandonRomano