Apply owners and the graph as part of composition

As all owners and setGraph are all idempotent
operations, we can apply them to NavController
as part of composition rather than via
DisposableEffect/SideEffect, thus ensuring that
they are set for the first composition.

Relnote: "Navigation Compose's `NavHost` now sets the
graph as part of the first composition."
Test: existing NavHostTest tests still pass

Change-Id: Ieb7be7689ab5c40cfcc52fefd70a87b406ce8c60

Author: ianhanniballake

navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavHost.kt

@@ -97,19 +97,15 @@ public fun NavHost(
     val onBackPressedDispatcherOwner = LocalOnBackPressedDispatcherOwner.current
     val onBackPressedDispatcher = onBackPressedDispatcherOwner?.onBackPressedDispatcher
 
-    // on successful recompose we setup the navController with proper inputs
-    // after the first time, this will only happen again if one of the inputs changes
-    DisposableEffect(navController, lifecycleOwner, viewModelStoreOwner, onBackPressedDispatcher) {
-        navController.setLifecycleOwner(lifecycleOwner)
-        navController.setViewModelStore(viewModelStoreOwner.viewModelStore)
-        if (onBackPressedDispatcher != null) {
-            navController.setOnBackPressedDispatcher(onBackPressedDispatcher)
-        }
-
-        onDispose { }
+    // Setup the navController with proper owners
+    navController.setLifecycleOwner(lifecycleOwner)
+    navController.setViewModelStore(viewModelStoreOwner.viewModelStore)
+    if (onBackPressedDispatcher != null) {
+        navController.setOnBackPressedDispatcher(onBackPressedDispatcher)
     }
 
-    SideEffect { navController.graph = graph }
+    // Then set the graph
+    navController.graph = graph
 
     val saveableStateHolder = rememberSaveableStateHolder()