Skip to content

Commit 6781729

Browse files
fixup! fixup! chore: naively set warn(unsafe_op_in_unsafe_fn) in wgpu-hal
1 parent 5a2d2c5 commit 6781729

File tree

2 files changed

+15
-19
lines changed

2 files changed

+15
-19
lines changed

wgpu-hal/src/vulkan/command.rs

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -488,28 +488,26 @@ impl crate::CommandEncoder<super::Api> for super::CommandEncoder {
488488
unsafe {
489489
self.device
490490
.raw
491-
.cmd_set_viewport(self.active, 0, &vk_viewports)
492-
};
493-
unsafe {
491+
.cmd_set_viewport(self.active, 0, &vk_viewports);
494492
self.device
495493
.raw
496-
.cmd_set_scissor(self.active, 0, &[render_area])
497-
};
498-
unsafe {
494+
.cmd_set_scissor(self.active, 0, &[render_area]);
499495
self.device.raw.cmd_begin_render_pass(
500496
self.active,
501497
&vk_info,
502498
vk::SubpassContents::INLINE,
503-
)
499+
);
504500
};
505501

506502
self.bind_point = vk::PipelineBindPoint::GRAPHICS;
507503
}
508504
unsafe fn end_render_pass(&mut self) {
509-
unsafe { self.device.raw.cmd_end_render_pass(self.active) };
510-
if self.rpass_debug_marker_active {
511-
unsafe { self.end_debug_marker() };
512-
self.rpass_debug_marker_active = false;
505+
unsafe {
506+
self.device.raw.cmd_end_render_pass(self.active);
507+
if self.rpass_debug_marker_active {
508+
self.end_debug_marker();
509+
self.rpass_debug_marker_active = false;
510+
}
513511
}
514512
}
515513

wgpu-hal/src/vulkan/device.rs

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1101,21 +1101,19 @@ impl crate::Device<super::Api> for super::Device {
11011101
})
11021102
}
11031103
unsafe fn destroy_command_encoder(&self, cmd_encoder: super::CommandEncoder) {
1104-
if !cmd_encoder.free.is_empty() {
1105-
unsafe {
1104+
unsafe {
1105+
if !cmd_encoder.free.is_empty() {
11061106
self.shared
11071107
.raw
11081108
.free_command_buffers(cmd_encoder.raw, &cmd_encoder.free)
1109-
};
1110-
}
1111-
if !cmd_encoder.discarded.is_empty() {
1112-
unsafe {
1109+
}
1110+
if !cmd_encoder.discarded.is_empty() {
11131111
self.shared
11141112
.raw
11151113
.free_command_buffers(cmd_encoder.raw, &cmd_encoder.discarded)
1116-
};
1114+
}
1115+
self.shared.raw.destroy_command_pool(cmd_encoder.raw, None);
11171116
}
1118-
unsafe { self.shared.raw.destroy_command_pool(cmd_encoder.raw, None) };
11191117
}
11201118

11211119
unsafe fn create_bind_group_layout(

0 commit comments

Comments
 (0)