Skip to content

Commit 6eada8f

Browse files
bors[bot]kvarkking6cong
committed
Merge #2164 #2166
2164: [mtl] Borrowed commands r=grovesNL a=kvark PR checklist: - [ ] `make` succeeds (on *nix) - [x] `make reftests` succeeds - [x] tested examples with the following backends: r? @gfx-rs/metallists This PR attempts to have lightweight software commands that don't take any heap space or own ObjC objects. In most cases, where a command list is live-recorded and executed once, this should reduce the amount of work we do per command, which is especially important if those commands are thrown away (e.g. because we are not inside a render pass). My expectation would be to see an improvement in #2161 due to us doing less work. The actual results are somewhat shocking: with v-sync enabled I'm getting the same 59-60 fps as usual. With v-sync OFF, I'm getting between 25 and 50 fps now (which is lower than the previous 50-70). Not sure what's going on, the instrumental profile doesn't give a clue. Please check out the code. 2166: Update example instructions in README.md r=kvark a=king6cong Co-authored-by: Dzmitry Malyshau <[email protected]> Co-authored-by: king6cong <[email protected]>
3 parents 0e1c915 + 90fd193 + 4c7a4ac commit 6eada8f

File tree

6 files changed

+1313
-843
lines changed

6 files changed

+1313
-843
lines changed

README.md

+5-1
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,12 @@ To run an example, simply use `cargo run` and specify the backend with `--featur
3636

3737
```bash
3838
git clone https://github.com/gfx-rs/gfx
39-
cd gfx/examples/hal
39+
cd gfx/examples
40+
# macOS
41+
cargo run --bin quad --features metal
42+
# vulkan
4043
cargo run --bin quad --features vulkan
44+
# Windows
4145
cargo run --bin compute --features dx12 1 2 3 4
4246
```
4347

0 commit comments

Comments
 (0)