diff --git a/static/app/views/alerts/rules/uptime/uptimeChecksGrid.tsx b/static/app/views/alerts/rules/uptime/uptimeChecksGrid.tsx index 1c2e3088590c78..e2bc0815a5381d 100644 --- a/static/app/views/alerts/rules/uptime/uptimeChecksGrid.tsx +++ b/static/app/views/alerts/rules/uptime/uptimeChecksGrid.tsx @@ -14,6 +14,7 @@ import {space} from 'sentry/styles/space'; import {getShortEventId} from 'sentry/utils/events'; import {MutableSearch} from 'sentry/utils/tokenizeSearch'; import type {UptimeCheck} from 'sentry/views/alerts/rules/uptime/types'; +import {CheckStatus} from 'sentry/views/alerts/rules/uptime/types'; import {useSpans} from 'sentry/views/insights/common/queries/useDiscover'; import { reasonToText, @@ -32,6 +33,8 @@ type Props = { */ const EMPTY_TRACE = '00000000000000000000000000000000'; +const emptyCell = '\u2014'; + /** * The number of system uptime spans that are always recorded for each uptime check. */ @@ -117,6 +120,8 @@ function CheckInBodyCell({ return ; } + const isMiss = checkStatus === CheckStatus.MISSED_WINDOW; + switch (column.key) { case 'timestamp': { return ( @@ -132,12 +137,18 @@ function CheckInBodyCell({ ); } case 'durationMs': + if (isMiss) { + return {emptyCell}; + } return ( ); case 'httpStatusCode': { + if (isMiss) { + return {emptyCell}; + } if (httpStatusCode === null) { return {t('None')}; } @@ -156,8 +167,8 @@ function CheckInBodyCell({ ); } case 'traceId': { - if (traceId === EMPTY_TRACE) { - return ; + if (isMiss || traceId === EMPTY_TRACE) { + return {emptyCell}; } const learnMore = ( @@ -210,6 +221,8 @@ function CheckInBodyCell({ ); } + case 'regionName': + return {isMiss ? emptyCell : check.regionName}; default: return {check[column.key]}; }