feat(aci): add description field to detector validator #102505
Merged
+37
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
kcons
reviewed
Oct 31, 2025
| def test_update_description(self) -> None: | ||
| assert self.detector.description is None | ||
|
|
||
| data = { |
There was a problem hiding this comment.
since i'm not quite sure of the convention for validators, is it worth testing that not providing a description doesn't make it go away, and that setting it to empty works? Probably not, right?
There was a problem hiding this comment.
I did write these tests initially, but it felt a bit excessive just for the description. These cases do work tho, I tested them locally 🙃
kcons
approved these changes
Oct 31, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #102505 +/- ##
===========================================
+ Coverage 80.82% 80.90% +0.07%
===========================================
Files 8826 8828 +2
Lines 390071 390084 +13
Branches 24799 24799
===========================================
+ Hits 315294 315579 +285
+ Misses 74426 74154 -272
Partials 351 351 |
jjbayer
pushed a commit
that referenced
this pull request
Nov 3, 2025
added `description` to the detector validator so users can add create/update detector descriptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added
descriptionto the detector validator so users can add create/update detector descriptions