feat(assisted-query): Add RPCs necessary for issues search #102137

roaga · 2025-10-27T15:43:18Z

Adds 3 new seer RPC endpoints:

given an org ID and a list of project IDs, gets all available attributes
given an org ID, a list of project IDs, an attribute key, and optionally a substring to match on, gets all available values for that attribute
given an org ID, a list of project IDs, and a query string and other params, calls and returns the response from the issues list endpoint (this will have the same data as the frontend gets)

codecov · 2025-10-27T15:48:31Z

Codecov Report

❌ Patch coverage is 85.81081% with 21 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
src/sentry/seer/assisted_query/issues_tools.py	86.20%	20 Missing ⚠️
src/sentry/seer/endpoints/seer_rpc.py	66.66%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #102137      +/-   ##
===========================================
- Coverage   81.06%    80.94%   -0.13%     
===========================================
  Files        8748      8752       +4     
  Lines      391254    389549    -1705     
  Branches    24693     24693              
===========================================
- Hits       317156    315304    -1852     
- Misses      73743     73890     +147     
  Partials      355       355

src/sentry/seer/assisted_query/tools.py

aliu39

lg, the main things are

avoiding the "attribute" naming (unless this is what the query agent understands best?)
only getting last 24h - maybe 7d would be better
adding built-in issue fields (see code ref) (can do in follow-up, up to you)

aliu39 · 2025-10-28T21:02:43Z

src/sentry/seer/assisted_query/tools.py

+logger = logging.getLogger(__name__)
+
+
+def get_issue_attributes(*, org_id: int, project_ids: list[int]) -> dict[str, Any] | None:


Suggested change

def get_issue_attributes(*, org_id: int, project_ids: list[int]) -> dict[str, Any] | None:

def get_issue_filter_keys(*, org_id: int, project_ids: list[int]) -> dict[str, Any] | None:

I think this or search_keys is more clear - attributes seems like a span-specific term.

As a follow-up there are more "built-in" keys we can add that are hard-coded - see

sentry/static/app/views/issueList/utils/useFetchIssueTags.tsx

Lines 207 to 212 in c33f13b

const additionalTags = builtInIssuesFields({

currentTags: renamedTags,

assigneeFieldValues: assignedValues,

bookmarksValues: usernames,

organization,

});

For ex assigned, first/last seen, issue type/category

are built in keys handled by the query builder's "strategy", or do we expect to return them here? @aayush-se

We should be returning built in keys since there may be specific values that may vary by org I think.

src/sentry/seer/assisted_query/tools.py

aliu39 · 2025-10-28T21:25:11Z

src/sentry/seer/assisted_query/tools.py

+    Args:
+        org_id: Organization ID
+        project_ids: List of project IDs to query
+        query: Search query string (e.g., "is:unresolved")


Curious how the agent does the query formatting? I guess that's in the assisted query agent? cc @aayush-se

The actual query/filter is just a string where the agent tries to adhere to the syntactical rules specified in the prompt which it follows pretty well

aliu39 · 2025-10-29T22:22:23Z

src/sentry/seer/assisted_query/tools.py

+        # If key already exists, we keep the first one (from events)
+        # Otherwise add the issue tag
+        if tag.get("key") not in tags_dict:
+            tags_dict[tag.get("key")] = tag


Should we merge totalValues?

hmm but then we would want to merge uniqueValues too, no? and i think that's overly complex

Ah ok fair - on that note does the agent even make use of either? Could maybe return just the keys

Idk, waiting for @aayush-se

totalValues as in the count of occurrences of a specific value? If so we don't need that.

I think it would be simpler if we just returned just the keys as @aliu39 mentioned. Don't need all that context up front as the agent should be making subsequent tool calls

aayush-se

Seems reasonable to me. I think there is probably some stuff that is extra (counts, totalValue) but can follow up based on what ends up being useful

aayush-se

just some nits, I think some of this can likely be cleaned up in this file. overall looks good

aayush-se · 2025-10-31T20:34:24Z

src/sentry/seer/assisted_query/issues_tools.py

+        is_values = [
+            "resolved",
+            "unresolved",
+            "archived",
+            "escalating",
+            "new",
+            "ongoing",
+            "regressed",
+            "assigned",
+            "unassigned",
+            "for_review",
+            "linked",
+            "unlinked",
+        ]


Can we pull this out into a constants file of some sorts? Seems like it is referenced a few times

aayush-se · 2025-10-31T20:35:42Z

src/sentry/seer/assisted_query/issues_tools.py

+        priority_values = [
+            PriorityLevel.HIGH.to_str(),
+            PriorityLevel.MEDIUM.to_str(),
+            PriorityLevel.LOW.to_str(),
+        ]


same here and for actionability, category_values, and attribute keys that have no suggested values available

aayush-se · 2025-10-31T20:44:41Z

src/sentry/seer/assisted_query/issues_tools.py

+    built_in_fields.append(
+        {
+            "key": "is",
+            "name": "Status",


why are you defining this name manually here? fwiw the agent just needs to know the public facing key name to create the query which the key itself should be enough for. Can these built in keys be pulled from the endpoints directly instead of hardcoded?

They unfortunately have to be hardcoded because there is no place on the backend where they can be referenced. But can remove the name field

sentry · 2025-11-02T02:49:20Z

Issues attributed to commits in this pull request

This pull request was merged and Sentry observed the following issues:

‼️ ApiError: status=400 body={'detail': 'Error parsin... in prod
‼️ ApiError: status=400 body={'detail': 'Invalid tag... in prod

Adds 3 new seer RPC endpoints: - given an org ID and a list of project IDs, gets all available attributes - given an org ID, a list of project IDs, an attribute key, and optionally a substring to match on, gets all available values for that attribute - given an org ID, a list of project IDs, and a query string and other params, calls and returns the response from the issues list endpoint (this will have the same data as the frontend gets)

JoshFerge · 2025-11-03T16:00:40Z

src/sentry/seer/assisted_query/issues_tools.py

+    flags_resp = client.get(
+        auth=api_key,
+        user=None,
+        path=f"/organizations/{organization.slug}/tags/",


you should be able to use organization id here, and it is a bit safer since slug is mutable

sentry/src/sentry/api/urls.py

Line 2359 in 3bb7520

r"^(?P<organization_id_or_slug>[^/]+)/tags/$",

JoshFerge · 2025-11-03T16:01:09Z

src/sentry/seer/assisted_query/issues_tools.py

+    events_resp = client.get(
+        auth=api_key,
+        user=None,
+        path=f"/organizations/{organization.slug}/tags/{attribute_key}/values/",


same here

sentry/src/sentry/api/urls.py

Line 2359 in 3bb7520

r"^(?P<organization_id_or_slug>[^/]+)/tags/$",

JoshFerge · 2025-11-03T16:02:30Z

src/sentry/seer/assisted_query/issues_tools.py

+    }
+
+
+def get_filter_key_values(


can probably do the requests in this RPC in a threadpool for parallelization speedup

Adds 3 new seer RPC endpoints: - given an org ID and a list of project IDs, gets all available attributes - given an org ID, a list of project IDs, an attribute key, and optionally a substring to match on, gets all available values for that attribute - given an org ID, a list of project IDs, and a query string and other params, calls and returns the response from the issues list endpoint (this will have the same data as the frontend gets)

Add RPCs necessary for issues search

2d97997

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 27, 2025

Fix typing

0364b66

vercel bot deployed to Preview October 27, 2025 16:07 View deployment

Rename file

f4d7852

vercel bot deployed to Preview October 27, 2025 16:19 View deployment

jasonyuezhang mentioned this pull request Oct 27, 2025

feat(assisted-query): Add RPCs for issue attributes and search jasonyuezhang/sentry#97

Open

fix tests

d93af3f

vercel bot deployed to Preview October 27, 2025 16:44 View deployment

roaga marked this pull request as ready for review October 27, 2025 17:02

roaga requested a review from a team as a code owner October 27, 2025 17:02

roaga requested a review from aayush-se October 27, 2025 17:02

This comment was marked as outdated.

Sign in to view

sentry bot reviewed Oct 27, 2025

View reviewed changes

src/sentry/seer/assisted_query/tools.py Outdated Show resolved Hide resolved

aliu39 reviewed Oct 28, 2025

View reviewed changes

PR feedback

4e96e75

vercel bot deployed to Preview October 29, 2025 16:05 View deployment

aliu39 reviewed Oct 29, 2025

View reviewed changes

aayush-se approved these changes Oct 30, 2025

View reviewed changes

Built in issues fields

c58979b

roaga requested a review from aayush-se October 31, 2025 18:48

vercel bot deployed to Preview October 31, 2025 18:50 View deployment

This comment was marked as outdated.

Sign in to view

Fix

e68ee80

vercel bot deployed to Preview October 31, 2025 18:54 View deployment

This comment was marked as outdated.

Sign in to view

aayush-se approved these changes Oct 31, 2025

View reviewed changes

cleanup

e3ac372

vercel bot deployed to Preview October 31, 2025 21:47 View deployment

This comment was marked as outdated.

Sign in to view

more cleanup

7d467b9

vercel bot deployed to Preview October 31, 2025 22:06 View deployment

comment

5f495fa

vercel bot deployed to Preview October 31, 2025 22:09 View deployment

roaga merged commit dd6f8c2 into master Oct 31, 2025
69 checks passed

roaga deleted the assisted-query/issues-rpcs branch October 31, 2025 22:50

JoshFerge reviewed Nov 3, 2025

View reviewed changes

		logger = logging.getLogger(__name__)


		def get_issue_attributes(*, org_id: int, project_ids: list[int]) -> dict[str, Any] \| None:

	def get_issue_attributes(*, org_id: int, project_ids: list[int]) -> dict[str, Any] \| None:
	def get_issue_filter_keys(*, org_id: int, project_ids: list[int]) -> dict[str, Any] \| None:

	const additionalTags = builtInIssuesFields({
	currentTags: renamedTags,
	assigneeFieldValues: assignedValues,
	bookmarksValues: usernames,
	organization,
	});

Uh oh!

feat(assisted-query): Add RPCs necessary for issues search #102137

feat(assisted-query): Add RPCs necessary for issues search #102137

Uh oh!

Conversation

roaga commented Oct 27, 2025

Uh oh!

codecov bot commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

aliu39 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

roaga Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aayush-se left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

aayush-se left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

sentry bot commented Nov 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issues attributed to commits in this pull request

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

codecov bot commented Oct 27, 2025 •

edited

Loading

aliu39 left a comment •

edited

Loading

roaga Oct 29, 2025 •

edited

Loading

sentry bot commented Nov 2, 2025 •

edited

Loading