feat(issues): Include empty tags in group tags endpoint #102049

scttcper · 2025-10-23T22:06:03Z

Add support for including empty tag values in the group tags endpoint (api/0/issues/{id}/tags/) when the organizations:issue-tags-include-empty-values feature flag is enabled.

Makes a 2nd snuba query and attaches the empty values. I couldn't figure out how to make this work in a single snuba query, but i did figure out how to do this without N snuba queries.

also needs some follow up frontend work

part of https://linear.app/getsentry/issue/RTC-1181/

Add support for including empty tag values in the group tags endpoint (api/0/issues/{id}/tags/) when the organizations:issue-tags-include-empty-values feature flag is enabled. Changes: - Add include_empty_values parameter to get_group_tag_keys_and_top_values methods - Add __get_empty_value_stats_map helper method to query empty tag stats - Update group_tags endpoint to check feature flag and pass parameter - Add feature flag organizations:issue-tags-include-empty-values - Add tests for empty tag inclusion behavior

linear · 2025-10-23T22:06:08Z

RTC-1181 The Issue Details tag list value percentages are misleading

src/sentry/tagstore/snuba/backend.py

src/sentry/tagstore/base.py

cvxluo · 2025-10-23T22:13:48Z

src/sentry/issues/endpoints/group_tags.py


+        include_empty_values = features.has(
+            "organizations:issue-tags-include-empty-values",
+            organization=group.project.organization,


if we're doing this on group.project.org, would making this a project option be better?

i just need it behind a flag, org is usually the easier one to roll out

codecov · 2025-10-23T22:21:38Z

Codecov Report

❌ Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
src/sentry/tagstore/snuba/backend.py	97.05%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #102049      +/-   ##
===========================================
+ Coverage   80.95%    80.97%   +0.02%     
===========================================
  Files        8797      8763      -34     
  Lines      389822    389456     -366     
  Branches    24800     24740      -60     
===========================================
- Hits       315588    315373     -215     
+ Misses      73860     73726     -134     
+ Partials      374       357      -17

cvxluo · 2025-10-23T22:18:19Z

src/sentry/features/temporary.py

    # Whether to allow issue only search on the issue list
    manager.add("organizations:issue-search-allow-postgres-only-search", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
+    # Include empty tag count in issue tag totals/values
+    manager.add("organizations:issue-tags-include-empty-values", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)


you mentioned you'll need this in the frontend, will you want api_expose=True?

I think in the frontend i can just handle empty strings and let the backend decide when to send them the value is "" which doesn't exist today.

cvxluo

i think this looks fine, and it makes sense to me, but i'd wait for an approval from someone more familiar with this endpoint

src/sentry/tagstore/snuba/backend.py

cvxluo · 2025-10-24T21:23:41Z

src/sentry/tagstore/snuba/backend.py

+                if not stats or stats.get("count", 0) <= 0:
+                    continue
+                vals = values_by_key.get(k, {})


nit: from my understanding think these need to be .get(), since empty_stats_map is either {} (so the iteration won't run) or are guarenteed to have k (same with above for count)?

cvxluo · 2025-10-24T21:25:57Z

tests/sentry/issues/endpoints/test_group_tags.py

+            response = self.client.get(url, format="json")
+        assert response.status_code == 200
+        values = {v["value"] for v in response.data[0]["topValues"]}
+        assert values == {"", "bar"}


can we also check that the empty tag count is correct (so response.data[0]["topValues"]["count"] is 1 or whatever)

wedamija

I'm kind of confused about why we want to allow this, what's the value of a tag with no name?

If a customer wants some dummy value, they can just write a tag with DUMMY as the name. Tbh, I don't think we should do this, especially since it causes an extra query

wedamija · 2025-10-27T17:41:23Z

src/sentry/tagstore/snuba/backend.py

+        empty_results = snuba.query(
+            dataset=dataset,
+            start=start,
+            end=end,
+            groupby=None,
+            conditions=conditions,
+            filter_keys=empty_filters,
+            aggregations=[],
+            selected_columns=selected_columns_empty,
+            referrer="tagstore._get_tag_keys_and_top_values_empty_counts",
+            tenant_ids=tenant_ids,
+        )


Are we going to end up making an extra query for every org to fetch these empty keys?

wedamija

Ok, I read through the linear and I understand what we're trying to do here... I'm going to think a little on the query and see if we can avoid a second one

cursor · 2025-10-28T17:40:29Z

src/sentry/tagstore/snuba/backend.py


-        # Then supplement the key objects with the top values for each.
+        if include_empty_values:
+            keys_to_check = list(values_by_key.keys()) or [k.key for k in keys_with_counts]


Bug: Tag Key Logic Fails with Empty Values

The keys_to_check logic in get_group_tag_keys_and_top_values incorrectly determines which keys to check for empty values. The expression list(values_by_key.keys()) or [k.key for k in keys_with_counts] can omit tags that only have empty values, especially when other tags have non-empty values or when specific keys are requested. This leads to incomplete tag data.

In #102049 added the empty tags, but noticing the total values no longer makes sense. Increases the total count when empty values is active

In #102049 added the empty tags, but noticing the total values no longer makes sense. Increases the total count when empty values is active part of https://linear.app/getsentry/issue/RTC-1181/

sentry · 2025-10-31T23:34:12Z

Issues attributed to commits in this pull request

This pull request was merged and Sentry observed the following issues:

‼️ SnubaError: After processing, query is 139172 byte... in prod
‼️ UnqualifiedQueryError: Validation failed for entit... in prod

Add support for including empty tag values in the group tags endpoint (api/0/issues/{id}/tags/) when the organizations:issue-tags-include-empty-values feature flag is enabled. Makes a 2nd snuba query and attaches the empty values. I couldn't figure out how to make this work in a single snuba query, but i did figure out how to do this without N snuba queries. also needs some follow up frontend work <img width="454" height="256" alt="image" src="https://github.com/user-attachments/assets/6b935125-7ed5-4418-bcbb-f4bbc7349990" /> part of https://linear.app/getsentry/issue/RTC-1181/

In #102049 added the empty tags, but noticing the total values no longer makes sense. Increases the total count when empty values is active part of https://linear.app/getsentry/issue/RTC-1181/

scttcper requested review from a team as code owners October 23, 2025 22:06

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 23, 2025

scttcper requested a review from wedamija October 23, 2025 22:06

seer-by-sentry bot reviewed Oct 23, 2025

View reviewed changes

src/sentry/tagstore/snuba/backend.py Outdated Show resolved Hide resolved

cleanup comment

167108a

vercel bot deployed to Preview October 23, 2025 22:11 View deployment

cvxluo reviewed Oct 23, 2025

View reviewed changes

=false

a43ed89

cvxluo reviewed Oct 23, 2025

View reviewed changes

vercel bot deployed to Preview October 23, 2025 22:24 View deployment

cvxluo approved these changes Oct 24, 2025

View reviewed changes

wedamija requested changes Oct 27, 2025

View reviewed changes

wedamija reviewed Oct 27, 2025

View reviewed changes

scttcper added 3 commits October 28, 2025 10:28

cleanup

d8a8df1

add another assertion

69076fe

Merge branch 'master' into scttcper/issue-tags-include-empty-values

d431559

vercel bot deployed to Preview October 28, 2025 17:38 View deployment

cursor bot reviewed Oct 28, 2025

View reviewed changes

wedamija approved these changes Oct 29, 2025

View reviewed changes

scttcper added 2 commits October 29, 2025 10:38

Merge branch 'master' into scttcper/issue-tags-include-empty-values

5f6506e

fix: include actor in feature flag check, fix org param

e56dcc8

vercel bot deployed to Preview October 29, 2025 18:13 View deployment

scttcper merged commit 4b8374d into master Oct 29, 2025
67 of 68 checks passed

scttcper deleted the scttcper/issue-tags-include-empty-values branch October 29, 2025 18:54

scttcper added a commit that referenced this pull request Oct 30, 2025

fix(issues): Increase top tag total value with empty keys

db79718

In #102049 added the empty tags, but noticing the total values no longer makes sense. Increases the total count when empty values is active

scttcper mentioned this pull request Oct 30, 2025

fix(issues): Increase top tag total value with empty keys #102378

Merged

Uh oh!

feat(issues): Include empty tags in group tags endpoint #102049

feat(issues): Include empty tags in group tags endpoint #102049

Conversation

scttcper commented Oct 23, 2025

Uh oh!

linear bot commented Oct 23, 2025

Uh oh!

Uh oh!

Uh oh!

cvxluo Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

scttcper Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

cvxluo Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

scttcper Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

cvxluo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cvxluo Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

cvxluo Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

wedamija left a comment

Choose a reason for hiding this comment

Uh oh!

wedamija Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

wedamija left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Oct 28, 2025

Choose a reason for hiding this comment

Bug: Tag Key Logic Fails with Empty Values

Uh oh!

Uh oh!

sentry bot commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issues attributed to commits in this pull request

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Oct 23, 2025 •

edited

Loading

sentry bot commented Oct 31, 2025 •

edited

Loading