ref(search): normalize parsed values (#69198)

JonasBa · getsantry[bot] · web-flow · commit c418650ab5ad · 2024-04-18T16:07:33.000Z
Normalize parsed values. Durations to ms, sizes to bytes, numbers to
spoiler alert (numbers), dates to dates and bools to "duh" bools

---------

Co-authored-by: getsantry[bot] &lt;66042841+getsantry[bot]@users.noreply.github.com&gt;
diff --git a/fixtures/search-syntax/aggregate_duration_filter.json b/fixtures/search-syntax/aggregate_duration_filter.json
@@ -31,7 +31,7 @@
           "type": "valueDuration",
           "value": "500",
           "unit": "s",
-          "parsed": {"value": 500, "unit": "s"}
+          "parsed": {"value": 500000}
         }
       },
       {"type": "spaces", "value": ""}
diff --git a/fixtures/search-syntax/aggregate_duration_filter_overrides_numeric_shorthand.json b/fixtures/search-syntax/aggregate_duration_filter_overrides_numeric_shorthand.json
@@ -32,7 +32,7 @@
           "type": "valueDuration",
           "value": "2",
           "unit": "m",
-          "parsed": {"value": 2, "unit": "m"}
+          "parsed": {"value": 120000}
         }
       },
       {"type": "spaces", "value": ""}
diff --git a/fixtures/search-syntax/aggregate_rel_time_filter.json b/fixtures/search-syntax/aggregate_rel_time_filter.json
@@ -21,8 +21,6 @@
           "sign": "+",
           "unit": "d",
           "parsed": {
-            "sign": "+",
-            "unit": "d",
             "value": "2017-10-24T02:41:20.000Z"
           }
         }
@@ -52,8 +50,6 @@
           "sign": "-",
           "unit": "w",
           "parsed": {
-            "sign": "-",
-            "unit": "w",
             "value": "2017-10-03T02:41:20.000Z"
           }
         }
diff --git a/fixtures/search-syntax/boolean_filter_passthrough.json b/fixtures/search-syntax/boolean_filter_passthrough.json
@@ -13,7 +13,7 @@
           "type": "valueNumber",
           "value": "1",
           "unit": null,
-          "parsed": {"value": 1, "unit": null}
+          "parsed": {"value": 1}
         }
       },
       {"type": "spaces", "value": ""}
diff --git a/fixtures/search-syntax/duration_aggregate_measurements_filter.json b/fixtures/search-syntax/duration_aggregate_measurements_filter.json
@@ -35,7 +35,7 @@
           "type": "valueDuration",
           "value": "3.3",
           "unit": "s",
-          "parsed": {"value": 3.3, "unit": "s"}
+          "parsed": {"value": 3300}
         }
       },
       {"type": "spaces", "value": ""}
@@ -77,7 +77,7 @@
           "type": "valueDuration",
           "value": "3.3",
           "unit": "s",
-          "parsed": {"value": 3.3, "unit": "s"}
+          "parsed": {"value": 3300}
         }
       },
       {"type": "spaces", "value": ""}
@@ -119,7 +119,7 @@
           "type": "valueDuration",
           "value": "3.3",
           "unit": "s",
-          "parsed": {"value": 3.3, "unit": "s"}
+          "parsed": {"value": 3300}
         }
       },
       {"type": "spaces", "value": ""}
diff --git a/fixtures/search-syntax/duration_aggregate_op_breakdowns_filter.json b/fixtures/search-syntax/duration_aggregate_op_breakdowns_filter.json
@@ -35,7 +35,7 @@
           "type": "valueDuration",
           "value": "3.3",
           "unit": "s",
-          "parsed": {"value": 3.3, "unit": "s"}
+          "parsed": {"value": 3300}
         }
       },
       {"type": "spaces", "value": ""}
@@ -77,7 +77,7 @@
           "type": "valueDuration",
           "value": "3.3",
           "unit": "s",
-          "parsed": {"value": 3.3, "unit": "s"}
+          "parsed": {"value": 3300}
         }
       },
       {"type": "spaces", "value": ""}
@@ -119,7 +119,7 @@
           "type": "valueDuration",
           "value": "3.3",
           "unit": "s",
-          "parsed": {"value": 3.3, "unit": "s"}
+          "parsed": {"value": 3300}
         }
       },
       {"type": "spaces", "value": ""}
diff --git a/fixtures/search-syntax/duration_filter.json b/fixtures/search-syntax/duration_filter.json
@@ -13,7 +13,7 @@
           "type": "valueDuration",
           "value": "500",
           "unit": "s",
-          "parsed": {"value": 500, "unit": "s"}
+          "parsed": {"value": 500000}
         }
       },
       {"type": "spaces", "value": ""}
@@ -33,7 +33,7 @@
           "type": "valueDuration",
           "value": "500",
           "unit": "s",
-          "parsed": {"value": 500, "unit": "s"}
+          "parsed": {"value": 500000}
         }
       },
       {"type": "spaces", "value": ""}
diff --git a/fixtures/search-syntax/duration_filter_overrides_numeric_shorthand.json b/fixtures/search-syntax/duration_filter_overrides_numeric_shorthand.json
@@ -14,7 +14,7 @@
           "type": "valueDuration",
           "value": "2",
           "unit": "m",
-          "parsed": {"value": 2, "unit": "m"}
+          "parsed": {"value": 120000}
         }
       },
       {"type": "spaces", "value": ""}
diff --git a/fixtures/search-syntax/duration_measurements_filter.json b/fixtures/search-syntax/duration_measurements_filter.json
@@ -13,7 +13,7 @@
           "type": "valueDuration",
           "value": "1.5",
           "unit": "s",
-          "parsed": {"value": 1.5, "unit": "s"}
+          "parsed": {"value": 1500}
         }
       },
       {"type": "spaces", "value": ""}
@@ -33,7 +33,7 @@
           "type": "valueDuration",
           "value": "1.5",
           "unit": "s",
-          "parsed": {"value": 1.5, "unit": "s"}
+          "parsed": {"value": 1500}
         }
       },
       {"type": "spaces", "value": ""}
@@ -53,7 +53,7 @@
           "type": "valueDuration",
           "value": "1.5",
           "unit": "s",
-          "parsed": {"value": 1.5, "unit": "s"}
+          "parsed": {"value": 1500}
         }
       },
       {"type": "spaces", "value": ""}
diff --git a/fixtures/search-syntax/duration_op_breakdowns_filter.json b/fixtures/search-syntax/duration_op_breakdowns_filter.json
@@ -13,7 +13,7 @@
           "type": "valueDuration",
           "value": "1.5",
           "unit": "s",
-          "parsed": {"value": 1.5, "unit": "s"}
+          "parsed": {"value": 1500}
         }
       },
       {"type": "spaces", "value": ""}
@@ -33,7 +33,7 @@
           "type": "valueDuration",
           "value": "1.5",
           "unit": "s",
-          "parsed": {"value": 1.5, "unit": "s"}
+          "parsed": {"value": 1500}
         }
       },
       {"type": "spaces", "value": ""}
@@ -53,7 +53,7 @@
           "type": "valueDuration",
           "value": "1.5",
           "unit": "s",
-          "parsed": {"value": 1.5, "unit": "s"}
+          "parsed": {"value": 1500}
         }
       },
       {"type": "spaces", "value": ""}
diff --git a/fixtures/search-syntax/numeric_aggregate_measurements_filter.json b/fixtures/search-syntax/numeric_aggregate_measurements_filter.json
@@ -31,7 +31,7 @@
           "type": "valueNumber",
           "value": "3.1415",
           "unit": null,
-          "parsed": {"value": 3.1415, "unit": null}
+          "parsed": {"value": 3.1415}
         }
       },
       {"type": "spaces", "value": ""}
@@ -69,7 +69,7 @@
           "type": "valueNumber",
           "value": "3.1415",
           "unit": null,
-          "parsed": {"value": 3.1415, "unit": null}
+          "parsed": {"value": 3.1415}
         }
       },
       {"type": "spaces", "value": ""}
@@ -107,7 +107,7 @@
           "type": "valueNumber",
           "value": "3.1415",
           "unit": null,
-          "parsed": {"value": 3.1415, "unit": null}
+          "parsed": {"value": 3.1415}
         }
       },
       {"type": "spaces", "value": ""}
@@ -145,7 +145,7 @@
           "type": "valueNumber",
           "value": "3",
           "unit": "k",
-          "parsed": {"value": 3000, "unit": "k"}
+          "parsed": {"value": 3000}
         }
       },
       {"type": "spaces", "value": ""}
@@ -183,7 +183,7 @@
           "type": "valueNumber",
           "value": "2",
           "unit": "m",
-          "parsed": {"value": 2000000, "unit": "m"}
+          "parsed": {"value": 2000000}
         }
       },
       {"type": "spaces", "value": ""}
diff --git a/fixtures/search-syntax/numeric_aggregate_op_breakdowns_filter.json b/fixtures/search-syntax/numeric_aggregate_op_breakdowns_filter.json
@@ -45,7 +45,6 @@
           "value": "3.1415",
           "unit": null,
           "parsed": {
-            "unit": null,
             "value": 3.1415
           }
         }
@@ -102,7 +101,6 @@
           "value": "3.1415",
           "unit": null,
           "parsed": {
-            "unit": null,
             "value": 3.1415
           }
         }
@@ -159,7 +157,6 @@
           "value": "3.1415",
           "unit": null,
           "parsed": {
-            "unit": null,
             "value": 3.1415
           }
         }
@@ -216,7 +213,6 @@
           "value": "3",
           "unit": "k",
           "parsed": {
-            "unit": "k",
             "value": 3000
           }
         }
@@ -274,8 +270,7 @@
           "value": "2",
           "unit": "m",
           "parsed": {
-            "unit": "m",
-            "value": 2
+            "value": 120000
           }
         }
       },
diff --git a/fixtures/search-syntax/numeric_filter.json b/fixtures/search-syntax/numeric_filter.json
@@ -60,7 +60,7 @@
           "type": "valueNumber",
           "value": "-500",
           "unit": null,
-          "parsed": {"value": -500, "unit": null}
+          "parsed": {"value": -500}
         }
       },
       {"type": "spaces", "value": ""}
@@ -80,7 +80,7 @@
           "type": "valueNumber",
           "value": "500",
           "unit": null,
-          "parsed": {"value": 500, "unit": null}
+          "parsed": {"value": 500}
         }
       },
       {"type": "spaces", "value": ""}
@@ -100,7 +100,7 @@
           "type": "valueNumber",
           "value": "500",
           "unit": null,
-          "parsed": {"value": 500, "unit": null}
+          "parsed": {"value": 500}
         }
       },
       {"type": "spaces", "value": ""}
diff --git a/fixtures/search-syntax/numeric_filter_with_decimals.json b/fixtures/search-syntax/numeric_filter_with_decimals.json
@@ -14,8 +14,7 @@
           "value": "3.1415",
           "unit": null,
           "parsed": {
-            "value": 3.1415,
-            "unit": null
+            "value": 3.1415
           }
         }
       },
diff --git a/fixtures/search-syntax/numeric_filter_with_shorthand.json b/fixtures/search-syntax/numeric_filter_with_shorthand.json
@@ -13,7 +13,7 @@
           "type": "valueNumber",
           "value": "3",
           "unit": "k",
-          "parsed": {"value": 3000, "unit": "k"}
+          "parsed": {"value": 3000}
         }
       },
       {"type": "spaces", "value": ""}
@@ -33,7 +33,7 @@
           "type": "valueNumber",
           "value": "3",
           "unit": "m",
-          "parsed": {"value": 3000000, "unit": "m"}
+          "parsed": {"value": 3000000}
         }
       },
       {"type": "spaces", "value": ""}
@@ -53,7 +53,7 @@
           "type": "valueNumber",
           "value": "3",
           "unit": "b",
-          "parsed": {"value": 3000000000, "unit": "b"}
+          "parsed": {"value": 3000000000}
         }
       },
       {"type": "spaces", "value": ""}
diff --git a/fixtures/search-syntax/numeric_in_filter.json b/fixtures/search-syntax/numeric_in_filter.json
diff --git a/fixtures/search-syntax/numeric_measurements_filter.json b/fixtures/search-syntax/numeric_measurements_filter.json
diff --git a/fixtures/search-syntax/rel_time_filter.json b/fixtures/search-syntax/rel_time_filter.json
diff --git a/fixtures/search-syntax/special_character_params.json b/fixtures/search-syntax/special_character_params.json
diff --git a/fixtures/search-syntax/supported_tags.json b/fixtures/search-syntax/supported_tags.json
diff --git a/static/app/components/parser b/static/app/components/parser
diff --git a/static/app/components/searchSyntax/parser.tsx b/static/app/components/searchSyntax/parser.tsx

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@`
`31`	`31`	`"type": "valueDuration",`
`32`	`32`	`"value": "500",`
`33`	`33`	`"unit": "s",`
`34`		`- "parsed": {"value": 500, "unit": "s"}`
	`34`	`+ "parsed": {"value": 500000}`
`35`	`35`	`}`
`36`	`36`	`},`
`37`	`37`	`{"type": "spaces", "value": ""}`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@`
`32`	`32`	`"type": "valueDuration",`
`33`	`33`	`"value": "2",`
`34`	`34`	`"unit": "m",`
`35`		`- "parsed": {"value": 2, "unit": "m"}`
	`35`	`+ "parsed": {"value": 120000}`
`36`	`36`	`}`
`37`	`37`	`},`
`38`	`38`	`{"type": "spaces", "value": ""}`
Original file line number	Diff line number	Diff line change
`@@ -21,8 +21,6 @@`
`21`	`21`	`"sign": "+",`
`22`	`22`	`"unit": "d",`
`23`	`23`	`"parsed": {`
`24`		`- "sign": "+",`
`25`		`- "unit": "d",`
`26`	`24`	`"value": "2017-10-24T02:41:20.000Z"`
`27`	`25`	`}`
`28`	`26`	`}`
`@@ -52,8 +50,6 @@`
`52`	`50`	`"sign": "-",`
`53`	`51`	`"unit": "w",`
`54`	`52`	`"parsed": {`
`55`		`- "sign": "-",`
`56`		`- "unit": "w",`
`57`	`53`	`"value": "2017-10-03T02:41:20.000Z"`
`58`	`54`	`}`
`59`	`55`	`}`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@`
`13`	`13`	`"type": "valueNumber",`
`14`	`14`	`"value": "1",`
`15`	`15`	`"unit": null,`
`16`		`- "parsed": {"value": 1, "unit": null}`
	`16`	`+ "parsed": {"value": 1}`
`17`	`17`	`}`
`18`	`18`	`},`
`19`	`19`	`{"type": "spaces", "value": ""}`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@`
`14`	`14`	`"type": "valueDuration",`
`15`	`15`	`"value": "2",`
`16`	`16`	`"unit": "m",`
`17`		`- "parsed": {"value": 2, "unit": "m"}`
	`17`	`+ "parsed": {"value": 120000}`
`18`	`18`	`}`
`19`	`19`	`},`
`20`	`20`	`{"type": "spaces", "value": ""}`