chore(commits): Remove create_commit dual write function (#102498)

We're no longer planning on using the dual written tables, so removing
these functions

<!-- Describe your PR here. -->

Author: wedamija

src/sentry/integrations/bitbucket/webhook.py

@@ -29,7 +29,6 @@
 from sentry.models.organization import Organization
 from sentry.models.repository import Repository
 from sentry.plugins.providers import IntegrationRepositoryProvider
-from sentry.releases.commits import create_commit
 from sentry.utils.email import parse_email
 
 logger = logging.getLogger("sentry.webhooks")
@@ -145,9 +144,9 @@ def __call__(self, event: Mapping[str, Any], **kwargs) -> None:
                     author = authors[author_email]
                 try:
                     with transaction.atomic(router.db_for_write(Commit)):
-                        create_commit(
-                            organization=organization,
-                            repo_id=repo.id,
+                        Commit.objects.create(
+                            repository_id=repo.id,
+                            organization_id=organization.id,
                             key=commit["hash"],
                             message=commit["message"],
                             author=author,

src/sentry/integrations/bitbucket_server/webhook.py

@@ -26,7 +26,6 @@
 from sentry.models.organization import Organization
 from sentry.models.repository import Repository
 from sentry.plugins.providers import IntegrationRepositoryProvider
-from sentry.releases.commits import create_commit
 from sentry.shared_integrations.exceptions import ApiHostError, ApiUnauthorized, IntegrationError
 from sentry.web.frontend.base import region_silo_view
 
@@ -132,9 +131,9 @@ def __call__(self, event: Mapping[str, Any], **kwargs) -> None:
                         author = authors[author_email]
                     try:
                         with transaction.atomic(router.db_for_write(Commit)):
-                            create_commit(
-                                organization=organization,
-                                repo_id=repo.id,
+                            Commit.objects.create(
+                                repository_id=repo.id,
+                                organization_id=organization.id,
                                 key=commit["id"],
                                 message=commit["message"],
                                 author=author,

src/sentry/integrations/github/webhook.py

@@ -46,7 +46,6 @@
     RepoExistsError,
     get_integration_repository_provider,
 )
-from sentry.releases.commits import create_commit
 from sentry.seer.autofix.webhooks import handle_github_pr_webhook_for_autofix
 from sentry.shared_integrations.exceptions import ApiError
 from sentry.users.services.user.service import user_service
@@ -444,9 +443,9 @@ def _handle(
                 author.preload_users()
             try:
                 with transaction.atomic(router.db_for_write(Commit)):
-                    c, _ = create_commit(
-                        organization=organization,
-                        repo_id=repo.id,
+                    c = Commit.objects.create(
+                        organization_id=organization.id,
+                        repository_id=repo.id,
                         key=commit["id"],
                         message=commit["message"],
                         author=author,

src/sentry/integrations/gitlab/webhooks.py

@@ -33,7 +33,6 @@
 from sentry.organizations.services.organization import organization_service
 from sentry.organizations.services.organization.model import RpcOrganization
 from sentry.plugins.providers import IntegrationRepositoryProvider
-from sentry.releases.commits import create_commit
 
 logger = logging.getLogger("sentry.webhooks")
 
@@ -252,9 +251,9 @@ def __call__(self, event: Mapping[str, Any], **kwargs):
                 if author is not None:
                     author.preload_users()
                 with transaction.atomic(router.db_for_write(Commit)):
-                    create_commit(
-                        organization=organization,
-                        repo_id=repo.id,
+                    Commit.objects.create(
+                        repository_id=repo.id,
+                        organization_id=organization.id,
                         key=commit["id"],
                         message=commit["message"],
                         author=author,

src/sentry/integrations/utils/commit_context.py

@@ -28,7 +28,6 @@
 from sentry.models.commit import Commit
 from sentry.models.commitauthor import CommitAuthor
 from sentry.models.organization import Organization
-from sentry.releases.commits import create_commit
 from sentry.shared_integrations.exceptions import ApiError
 from sentry.utils import metrics
 from sentry.utils.committers import get_stacktrace_path_from_event_frame
@@ -159,9 +158,9 @@ def get_or_create_commit_from_blame(
             email=blame.commit.commitAuthorEmail,
             defaults={"name": blame.commit.commitAuthorName},
         )
-        commit, _ = create_commit(
-            organization=Organization.objects.get(id=organization_id),
-            repo_id=blame.repo.id,
+        commit = Commit.objects.create(
+            organization_id=organization_id,
+            repository_id=blame.repo.id,
             key=blame.commit.commitId,
             date_added=blame.commit.committedDate,
             author=commit_author,

src/sentry/releases/commits.py

@@ -1,13 +1,7 @@
 import logging
-from datetime import datetime
-
-from django.db import router
 
 from sentry.models.commit import Commit as OldCommit
-from sentry.models.commitauthor import CommitAuthor
-from sentry.models.organization import Organization
 from sentry.releases.models import Commit
-from sentry.utils.db import atomic_transaction
 
 logger = logging.getLogger(__name__)
 
@@ -35,33 +29,3 @@ def _dual_write_commit(old_commit: OldCommit) -> Commit:
             },
         )
     return new_commit
-
-
-def create_commit(
-    organization: Organization,
-    repo_id: int,
-    key: str,
-    message: str | None = None,
-    author: CommitAuthor | None = None,
-    date_added: datetime | None = None,
-) -> tuple[OldCommit, Commit]:
-    with atomic_transaction(
-        using=(
-            router.db_for_write(OldCommit),
-            router.db_for_write(Commit),
-        )
-    ):
-        commit_kwargs = {}
-        if date_added is not None:
-            commit_kwargs["date_added"] = date_added
-
-        old_commit = OldCommit.objects.create(
-            organization_id=organization.id,
-            repository_id=repo_id,
-            key=key,
-            author=author,
-            message=message,
-            **commit_kwargs,
-        )
-        new_commit = _dual_write_commit(old_commit)
-    return old_commit, new_commit

src/sentry_plugins/bitbucket/endpoints/webhook.py

@@ -14,11 +14,9 @@
 from sentry.integrations.bitbucket.constants import BITBUCKET_IP_RANGES, BITBUCKET_IPS
 from sentry.models.commit import Commit
 from sentry.models.commitauthor import CommitAuthor
-from sentry.models.organization import Organization
 from sentry.models.repository import Repository
 from sentry.organizations.services.organization.service import organization_service
 from sentry.plugins.providers import RepositoryProvider
-from sentry.releases.commits import create_commit
 from sentry.utils import json
 from sentry.utils.email import parse_email
 
@@ -48,10 +46,6 @@ def __call__(self, organization_id: int, event):
             repo.config["name"] = event["repository"]["full_name"]
             repo.save()
 
-        try:
-            organization = Organization.objects.get(id=organization_id)
-        except Organization.DoesNotExist:
-            raise Http404()
         for change in event["push"]["changes"]:
             for commit in change.get("commits", []):
                 if RepositoryProvider.should_ignore_commit(commit["message"]):
@@ -73,9 +67,9 @@ def __call__(self, organization_id: int, event):
                     author = authors[author_email]
                 try:
                     with transaction.atomic(router.db_for_write(Commit)):
-                        create_commit(
-                            organization=organization,
-                            repo_id=repo.id,
+                        Commit.objects.create(
+                            repository_id=repo.id,
+                            organization_id=organization_id,
                             key=commit["hash"],
                             message=commit["message"],
                             author=author,

src/sentry_plugins/github/webhooks/events/push.py

@@ -15,7 +15,6 @@
 from sentry.models.organization import Organization
 from sentry.models.repository import Repository
 from sentry.plugins.providers import RepositoryProvider
-from sentry.releases.commits import create_commit
 from sentry.shared_integrations.exceptions import ApiError
 from sentry.users.services.user.service import user_service
 from sentry_plugins.github.client import GithubPluginClient
@@ -40,11 +39,6 @@ def _handle(self, event, organization_id, is_apps):
         except Repository.DoesNotExist:
             raise Http404()
 
-        try:
-            organization = Organization.objects.get(id=organization_id)
-        except Organization.DoesNotExist:
-            raise Http404()
-
         # We need to track GitHub's "full_name" which is the repository slug.
         # This is needed to access the API since `external_id` isn't sufficient.
         if repo.config.get("name") != event["repository"]["full_name"]:
@@ -147,9 +141,9 @@ def _handle(self, event, organization_id, is_apps):
 
             try:
                 with transaction.atomic(router.db_for_write(Commit)):
-                    c, _ = create_commit(
-                        organization=organization,
-                        repo_id=repo.id,
+                    c = Commit.objects.create(
+                        repository_id=repo.id,
+                        organization_id=organization_id,
                         key=commit["id"],
                         message=commit["message"],
                         author=author,