remove sentry app outbox flag

Author: cathteng

src/sentry/options/defaults.py

@@ -3174,13 +3174,6 @@
     flags=FLAG_AUTOMATOR_MODIFIABLE,
 )
 
-register(
-    "workflow_engine.sentry-app-actions-outbox",
-    type=Bool,
-    default=False,
-    flags=FLAG_AUTOMATOR_MODIFIABLE,
-)
-
 register(
     "workflow_engine.num_cohorts",
     type=Int,

src/sentry/receivers/outbox/control.py

@@ -14,7 +14,6 @@
 
 from django.dispatch import receiver
 
-from sentry import options
 from sentry.constants import ObjectStatus
 from sentry.hybridcloud.outbox.category import OutboxCategory
 from sentry.hybridcloud.outbox.signals import process_control_outbox
@@ -65,27 +64,17 @@ def process_sentry_app_deletes(
     payload: Mapping[str, Any],
     **kwds: Any,
 ):
-    # This function should only be used when the sentry app is being deleted.
-    # Currently this receiver is only used for deletion.
-    if options.get("workflow_engine.sentry-app-actions-outbox"):
-        logger.info(
-            "sentry_app_update.update_action_status",
-            extra={
-                "region_name": region_name,
-                "sentry_app_id": object_identifier,
-            },
-        )
-        action_service.update_action_status_for_sentry_app_via_sentry_app_id(
+    action_service.update_action_status_for_sentry_app_via_sentry_app_id(
+        region_name=region_name,
+        status=ObjectStatus.DISABLED,
+        sentry_app_id=object_identifier,
+    )
+    if slug := payload.get("slug"):
+        action_service.update_action_status_for_webhook_via_sentry_app_slug(
             region_name=region_name,
             status=ObjectStatus.DISABLED,
-            sentry_app_id=object_identifier,
+            sentry_app_slug=slug,
         )
-        if slug := payload.get("slug"):
-            action_service.update_action_status_for_webhook_via_sentry_app_slug(
-                region_name=region_name,
-                status=ObjectStatus.DISABLED,
-                sentry_app_slug=slug,
-            )
 
 
 @receiver(process_control_outbox, sender=OutboxCategory.SENTRY_APP_INSTALLATION_DELETE)
@@ -96,21 +85,11 @@ def process_sentry_app_installation_deletes(
     payload: Mapping[str, Any],
     **kwds: Any,
 ):
-    # This function should only be used when the sentry app is being deleted.
-    # Currently this receiver is only used for deletion.
-    if options.get("workflow_engine.sentry-app-actions-outbox"):
-        logger.info(
-            "sentry_app_installation_delete.update_action_status",
-            extra={
-                "region_name": region_name,
-                "sentry_app_install_uuid": payload["uuid"],
-            },
-        )
-        action_service.update_action_status_for_sentry_app_via_uuid__region(
-            region_name=region_name,
-            status=ObjectStatus.DISABLED,
-            sentry_app_install_uuid=payload["uuid"],
-        )
+    action_service.update_action_status_for_sentry_app_via_uuid__region(
+        region_name=region_name,
+        status=ObjectStatus.DISABLED,
+        sentry_app_install_uuid=payload["uuid"],
+    )
 
 
 @receiver(process_control_outbox, sender=OutboxCategory.API_APPLICATION_UPDATE)