fix test

Author: mifu67

src/sentry/incidents/grouptype.py

@@ -16,6 +16,7 @@
 from sentry.issues.grouptype import GroupCategory, GroupType
 from sentry.models.organization import Organization
 from sentry.ratelimits.sliding_windows import Quota
+from sentry.seer.anomaly_detection.delete_rule import delete_data_in_seer_for_detector
 from sentry.snuba.dataset import Dataset
 from sentry.snuba.metrics import format_mri_field, is_mri_field
 from sentry.snuba.models import QuerySubscription, SnubaQuery
@@ -27,7 +28,12 @@
 from sentry.workflow_engine.models.data_condition import Condition, DataCondition
 from sentry.workflow_engine.models.data_source import DataPacket
 from sentry.workflow_engine.processors.data_condition_group import ProcessedDataConditionGroup
-from sentry.workflow_engine.types import DetectorException, DetectorPriorityLevel, DetectorSettings
+from sentry.workflow_engine.types import (
+    DetectorException,
+    DetectorLifeCycleHooks,
+    DetectorPriorityLevel,
+    DetectorSettings,
+)
 
 logger = logging.getLogger(__name__)
 
@@ -353,4 +359,5 @@ class MetricIssue(GroupType):
                 },
             },
         },
+        hooks=DetectorLifeCycleHooks(pending_delete=delete_data_in_seer_for_detector),
     )

src/sentry/seer/anomaly_detection/delete_rule.py

@@ -20,6 +20,36 @@
 
 if TYPE_CHECKING:
     from sentry.incidents.models.alert_rule import AlertRule
+    from sentry.workflow_engine.models.detector import Detector
+
+
+def delete_data_in_seer_for_detector(detector: "Detector"):
+    from sentry.incidents.models.alert_rule import AlertRuleDetectionType
+    from sentry.workflow_engine.models import DataSourceDetector
+
+    data_source_detector = DataSourceDetector.objects.filter(detector_id=detector.id).first()
+    if not data_source_detector:
+        logger.error(
+            "No data source found for detector",
+            extra={
+                "detector_id": detector.id,
+            },
+        )
+        return
+
+    organization = detector.project.organization
+
+    if detector.config.get("detection_type") == AlertRuleDetectionType.DYNAMIC:
+        success = delete_rule_in_seer(
+            source_id=data_source_detector.data_source_id, organization=organization
+        )
+        if not success:
+            logger.error(
+                "Call to delete rule data in Seer failed",
+                extra={
+                    "detector_id": detector.id,
+                },
+            )
 
 
 def delete_rule_in_seer(source_id: int, organization: Organization) -> bool:

src/sentry/workflow_engine/endpoints/organization_detector_details.py

@@ -28,19 +28,17 @@
 from sentry.grouping.grouptype import ErrorGroupType
 from sentry.incidents.grouptype import MetricIssue
 from sentry.incidents.metric_issue_detector import schedule_update_project_config
-from sentry.incidents.models.alert_rule import AlertRuleDetectionType
 from sentry.issues import grouptype
 from sentry.models.organization import Organization
 from sentry.models.project import Project
-from sentry.seer.anomaly_detection.delete_rule import delete_rule_in_seer
 from sentry.utils.audit import create_audit_entry
 from sentry.workflow_engine.endpoints.serializers.detector_serializer import DetectorSerializer
 from sentry.workflow_engine.endpoints.validators.detector_workflow import (
     BulkDetectorWorkflowsValidator,
     can_edit_detector,
 )
 from sentry.workflow_engine.endpoints.validators.utils import get_unknown_detector_type_error
-from sentry.workflow_engine.models import DataSourceDetector, Detector
+from sentry.workflow_engine.models import Detector
 from sentry.workflow_engine.types import DetectorLifeCycleHooks
 
 logger = logging.getLogger(__name__)
@@ -216,25 +214,6 @@ def delete(self, request: Request, organization: Organization, detector: Detecto
         if detector.type == MetricIssue.slug:
             schedule_update_project_config(detector)
 
-            data_source_detector = DataSourceDetector.objects.filter(
-                detector_id=detector.id
-            ).first()
-            if not data_source_detector:
-                return Response(status=404)
-
-            if detector.config.get("detection_type") == AlertRuleDetectionType.DYNAMIC:
-                success = delete_rule_in_seer(
-                    source_id=data_source_detector.data_source_id, organization=organization
-                )
-                # We don't need to surface this to the user, but we should know about it.
-                if not success:
-                    logger.error(
-                        "Call to delete rule data in Seer failed",
-                        extra={
-                            "detector_id": detector.id,
-                        },
-                    )
-
         RegionScheduledDeletion.schedule(detector, days=0, actor=request.user)
         detector.update(status=ObjectStatus.PENDING_DELETION)
 

tests/sentry/workflow_engine/endpoints/test_organization_detector_details.py

@@ -752,9 +752,7 @@ def test_error_group_type(self) -> None:
             ).exists()
 
     @with_feature("organizations:anomaly-detection-alerts")
-    @mock.patch(
-        "sentry.workflow_engine.endpoints.organization_detector_details.delete_rule_in_seer"
-    )
+    @mock.patch("sentry.seer.anomaly_detection.delete_rule.delete_rule_in_seer")
     @mock.patch(
         "sentry.workflow_engine.endpoints.organization_detector_details.schedule_update_project_config"
     )