feat(preprod): Save android_app_info to extras if present (#102454)

Save android_app_info to extras if present.

Author: rbro112

src/sentry/preprod/api/endpoints/project_preprod_artifact_update.py

@@ -62,6 +62,12 @@ def validate_preprod_artifact_update_schema(
                     "missing_dsym_binaries": {"type": "array", "items": {"type": "string"}},
                 },
             },
+            "android_app_info": {
+                "type": "object",
+                "properties": {
+                    "has_proguard_mapping": {"type": "boolean"},
+                },
+            },
             "dequeued_at": {"type": "string"},
             "app_icon_id": {"type": "string", "maxLength": 255},
         },
@@ -84,6 +90,8 @@ def validate_preprod_artifact_update_schema(
         "apple_app_info.is_code_signature_valid": "The is_code_signature_valid field must be a boolean.",
         "apple_app_info.code_signature_errors": "The code_signature_errors field must be an array of strings.",
         "apple_app_info.missing_dsym_binaries": "The missing_dsym_binaries field must be an array of strings.",
+        "android_app_info": "The android_app_info field must be an object.",
+        "android_app_info.has_proguard_mapping": "The has_proguard_mapping field must be a boolean.",
         "dequeued_at": "The dequeued_at field must be a string.",
         "app_icon_id": "The app_icon_id field must be a string with a maximum length of 255 characters.",
     }
@@ -319,6 +327,12 @@ def put(
                 if field in apple_info:
                     extras_updates[field] = apple_info[field]
 
+        if "android_app_info" in data:
+            android_info = data["android_app_info"]
+            for field in ["has_proguard_mapping"]:
+                if field in android_info:
+                    extras_updates[field] = android_info[field]
+
         if "dequeued_at" in data:
             extras_updates["dequeued_at"] = data["dequeued_at"]
 

src/sentry/preprod/api/models/project_preprod_build_details_models.py

@@ -22,6 +22,10 @@ class AppleAppInfo(BaseModel):
     missing_dsym_binaries: list[str] = []
 
 
+class AndroidAppInfo(BaseModel):
+    has_proguard_mapping: bool = True
+
+
 class BuildDetailsAppInfo(BaseModel):
     app_id: str | None
     name: str | None
@@ -34,6 +38,7 @@ class BuildDetailsAppInfo(BaseModel):
     is_installable: bool
     build_configuration: str | None = None
     apple_app_info: AppleAppInfo | None = None
+    android_app_info: AndroidAppInfo | None = None
 
 
 class BuildDetailsVcsInfo(BaseModel):
@@ -140,11 +145,26 @@ def transform_preprod_artifact_to_build_details(
 
     size_info = to_size_info(size_metrics)
 
-    apple_app_info = AppleAppInfo(
-        missing_dsym_binaries=(
-            artifact.extras.get("missing_dsym_binaries", []) if artifact.extras else []
+    platform = None
+    # artifact_type can be null before preprocessing has completed
+    if artifact.artifact_type is not None:
+        platform = platform_from_artifact_type(artifact.artifact_type)
+
+    apple_app_info = None
+    if platform == Platform.IOS or platform == Platform.MACOS:
+        apple_app_info = AppleAppInfo(
+            missing_dsym_binaries=(
+                artifact.extras.get("missing_dsym_binaries", []) if artifact.extras else []
+            )
+        )
+
+    android_app_info = None
+    if platform == Platform.ANDROID:
+        android_app_info = AndroidAppInfo(
+            has_proguard_mapping=(
+                artifact.extras.get("has_proguard_mapping", True) if artifact.extras else True
+            )
         )
-    )
 
     app_info = BuildDetailsAppInfo(
         app_id=artifact.app_id,
@@ -164,6 +184,7 @@ def transform_preprod_artifact_to_build_details(
             artifact.build_configuration.name if artifact.build_configuration else None
         ),
         apple_app_info=apple_app_info,
+        android_app_info=android_app_info,
     )
 
     vcs_info = BuildDetailsVcsInfo(

tests/sentry/preprod/api/endpoints/test_project_preprod_artifact_update.py

@@ -179,6 +179,30 @@ def test_update_preprod_artifact_with_apple_app_info(self) -> None:
         stored_apple_info = self.preprod_artifact.extras or {}
         assert stored_apple_info == apple_info
 
+    @override_settings(LAUNCHPAD_RPC_SHARED_SECRET=["test-secret-key"])
+    def test_update_preprod_artifact_with_android_app_info(self) -> None:
+        android_info = {
+            "has_proguard_mapping": True,
+        }
+        data = {
+            "date_built": "2024-01-01T00:00:00Z",
+            "artifact_type": 2,
+            "build_version": "1.2.3",
+            "build_number": 123,
+            "android_app_info": android_info,
+        }
+        response = self._make_request(data)
+
+        assert response.status_code == 200
+        resp_data = response.json()
+        assert resp_data["success"] is True
+        assert "extras" in resp_data["updatedFields"]
+
+        self.preprod_artifact.refresh_from_db()
+        stored_android_info = self.preprod_artifact.extras or {}
+        assert stored_android_info == android_info
+        assert stored_android_info["has_proguard_mapping"] is True
+
     @override_settings(LAUNCHPAD_RPC_SHARED_SECRET=["test-secret-key"])
     def test_update_preprod_artifact_with_missing_dsym_binaries_truncation(self) -> None:
         """Test that missing_dsym_binaries list is truncated if it exceeds 1024 chars."""

tests/sentry/preprod/api/endpoints/test_project_preprod_build_details.py

@@ -229,6 +229,7 @@ def test_size_info_none_when_no_metrics(self) -> None:
 
     def test_get_build_details_with_missing_dsym_binaries(self) -> None:
         """Test that missing_dsym_binaries is returned in apple_app_info."""
+        self.preprod_artifact.artifact_type = PreprodArtifact.ArtifactType.XCARCHIVE
         self.preprod_artifact.extras = {
             "missing_dsym_binaries": ["libTest.dylib", "TestFramework.framework"]
         }
@@ -241,7 +242,24 @@ def test_get_build_details_with_missing_dsym_binaries(self) -> None:
 
         assert response.status_code == 200
         resp_data = response.json()
+
         assert resp_data["app_info"]["apple_app_info"]["missing_dsym_binaries"] == [
             "libTest.dylib",
             "TestFramework.framework",
         ]
+        assert resp_data["app_info"]["android_app_info"] is None
+
+    def test_get_build_details_with_missing_proguard_mapping(self) -> None:
+        """Test that has_proguard_mapping is returned in android_app_info."""
+        self.preprod_artifact.extras = {"has_proguard_mapping": False}
+        self.preprod_artifact.save()
+
+        url = self._get_url()
+        response = self.client.get(
+            url, format="json", HTTP_AUTHORIZATION=f"Bearer {self.api_token.token}"
+        )
+
+        assert response.status_code == 200
+        resp_data = response.json()
+        assert resp_data["app_info"]["android_app_info"]["has_proguard_mapping"] is False
+        assert resp_data["app_info"]["apple_app_info"] is None