test(issues): Migrate issue detail tests from deprecatedRouterMocks to initialRouterConfig (#102725)

scttcper · web-flow · commit 2d0700d3b0d9 · 2025-11-04T21:34:57.000Z
diff --git a/static/app/views/issueDetails/groupActivity.spec.tsx b/static/app/views/issueDetails/groupActivity.spec.tsx
@@ -3,7 +3,6 @@ import {OrganizationFixture} from 'sentry-fixture/organization';
 import {ProjectFixture} from 'sentry-fixture/project';
 import {ReleaseFixture} from 'sentry-fixture/release';
 import {RepositoryFixture} from 'sentry-fixture/repository';
-import {RouterFixture} from 'sentry-fixture/routerFixture';
 import {TeamFixture} from 'sentry-fixture/team';
 import {UserFixture} from 'sentry-fixture/user';
 
@@ -13,6 +12,7 @@ import {
   screen,
   userEvent,
   waitFor,
+  type RouterConfig,
 } from 'sentry-test/reactTestingLibrary';
 
 import ConfigStore from 'sentry/stores/configStore';
@@ -66,9 +66,12 @@ describe('GroupActivity', () => {
     GroupStore.add([group]);
     // XXX: Explicitly using legacy UI since this component is not used in the new one
     const organization = OrganizationFixture({streamlineOnly: false});
-    const router = RouterFixture({
-      params: {orgId: organization.slug, groupId: group.id},
-    });
+    const initialRouterConfig: RouterConfig = {
+      location: {
+        pathname: `/organizations/${organization.slug}/issues/${group.id}/activity/`,
+      },
+      route: `/organizations/:orgId/issues/:groupId/activity/`,
+    };
 
     MockApiClient.addMockResponse({
       url: `/organizations/${organization.slug}/issues/${group.id}/`,
@@ -78,9 +81,8 @@ describe('GroupActivity', () => {
     TeamStore.loadInitialData([TeamFixture({id: '999', slug: 'no-team'})]);
     OrganizationStore.onUpdate(organization, {replace: true});
     render(<GroupActivity />, {
-      router,
       organization,
-      deprecatedRouterMocks: true,
+      initialRouterConfig,
     });
   }
 
diff --git a/static/app/views/issueDetails/groupCheckIns.spec.tsx b/static/app/views/issueDetails/groupCheckIns.spec.tsx
@@ -3,9 +3,8 @@ import {EventFixture} from 'sentry-fixture/event';
 import {GroupFixture} from 'sentry-fixture/group';
 import {OrganizationFixture} from 'sentry-fixture/organization';
 import {ProjectFixture} from 'sentry-fixture/project';
-import {RouterFixture} from 'sentry-fixture/routerFixture';
 
-import {render, screen} from 'sentry-test/reactTestingLibrary';
+import {render, screen, type RouterConfig} from 'sentry-test/reactTestingLibrary';
 
 import GroupStore from 'sentry/stores/groupStore';
 import {IssueCategory, IssueType} from 'sentry/types/group';
@@ -29,7 +28,12 @@ describe('GroupCheckIns', () => {
     project,
   });
   const organization = OrganizationFixture();
-  const router = RouterFixture({params: {groupId: group.id}});
+  const initialRouterConfig: RouterConfig = {
+    location: {
+      pathname: `/organizations/${organization.slug}/issues/${group.id}/check-ins/`,
+    },
+    route: `/organizations/:orgId/issues/:groupId/check-ins/`,
+  };
 
   beforeEach(() => {
     GroupStore.init();
@@ -53,8 +57,7 @@ describe('GroupCheckIns', () => {
 
     render(<GroupCheckIns />, {
       organization,
-      router,
-      deprecatedRouterMocks: true,
+      initialRouterConfig,
     });
     expect(await screen.findByText('All Check-Ins')).toBeInTheDocument();
     expect(
@@ -71,8 +74,7 @@ describe('GroupCheckIns', () => {
 
     render(<GroupCheckIns />, {
       organization,
-      router,
-      deprecatedRouterMocks: true,
+      initialRouterConfig,
     });
     expect(await screen.findByText('All Check-Ins')).toBeInTheDocument();
     expect(screen.queryByText('No matching check-ins found')).not.toBeInTheDocument();
diff --git a/static/app/views/issueDetails/groupEventAttachments/groupEventAttachments.spec.tsx b/static/app/views/issueDetails/groupEventAttachments/groupEventAttachments.spec.tsx
@@ -1,18 +1,19 @@
 import {EnvironmentsFixture} from 'sentry-fixture/environments';
 import {EventAttachmentFixture} from 'sentry-fixture/eventAttachment';
 import {GroupFixture} from 'sentry-fixture/group';
+import {OrganizationFixture} from 'sentry-fixture/organization';
 import {ProjectFixture} from 'sentry-fixture/project';
 import {TagsFixture} from 'sentry-fixture/tags';
 import {UserFixture} from 'sentry-fixture/user';
 
-import {initializeOrg} from 'sentry-test/initializeOrg';
 import {
   act,
   render,
   renderGlobalModal,
   screen,
   userEvent,
   within,
+  type RouterConfig,
 } from 'sentry-test/reactTestingLibrary';
 
 import ConfigStore from 'sentry/stores/configStore';
@@ -25,19 +26,24 @@ import GroupEventAttachments from './groupEventAttachments';
 describe('GroupEventAttachments', () => {
   const groupId = 'group-id';
   const group = GroupFixture({id: groupId});
-  const {organization, router} = initializeOrg({
-    organization: {
-      features: ['event-attachments'],
-      orgRole: 'member',
-      attachmentsRole: 'member',
-    },
+  const organization = OrganizationFixture({
+    features: ['event-attachments'],
+    orgRole: 'member',
+    attachmentsRole: 'member',
   });
-  const {router: screenshotRouter} = initializeOrg({
-    router: {
-      params: {orgId: 'org-slug', groupId: 'group-id'},
-      location: {query: {attachmentFilter: 'screenshot'}},
+  const initialRouterConfig: RouterConfig = {
+    location: {
+      pathname: `/organizations/${organization.slug}/issues/${groupId}/attachments/`,
     },
-  });
+    route: `/organizations/:orgId/issues/:groupId/attachments/`,
+  };
+  const screenshotRouterConfig: RouterConfig = {
+    location: {
+      pathname: `/organizations/${organization.slug}/issues/${groupId}/attachments/`,
+      query: {attachmentFilter: 'screenshot'},
+    },
+    route: `/organizations/:orgId/issues/:groupId/attachments/`,
+  };
   let project: Project;
   let getAttachmentsMock: jest.Mock;
 
@@ -67,9 +73,8 @@ describe('GroupEventAttachments', () => {
 
   it('calls attachments api with screenshot filter', async () => {
     render(<GroupEventAttachments project={project} group={group} />, {
-      router: screenshotRouter,
       organization,
-      deprecatedRouterMocks: true,
+      initialRouterConfig: screenshotRouterConfig,
     });
     expect(screen.getByRole('radio', {name: 'Screenshots'})).toBeInTheDocument();
     await userEvent.click(screen.getByRole('radio', {name: 'Screenshots'}));
@@ -87,9 +92,8 @@ describe('GroupEventAttachments', () => {
 
   it('calls opens modal when clicking on panel body', async () => {
     render(<GroupEventAttachments project={project} group={group} />, {
-      router: screenshotRouter,
       organization,
-      deprecatedRouterMocks: true,
+      initialRouterConfig: screenshotRouterConfig,
     });
     renderGlobalModal();
     await userEvent.click(await screen.findByTestId('screenshot-1'));
@@ -98,9 +102,8 @@ describe('GroupEventAttachments', () => {
 
   it('links event id to event detail', async () => {
     render(<GroupEventAttachments project={project} group={group} />, {
-      router,
       organization,
-      deprecatedRouterMocks: true,
+      initialRouterConfig,
     });
     expect(await screen.findByRole('link', {name: '12345678'})).toHaveAttribute(
       'href',
@@ -110,9 +113,8 @@ describe('GroupEventAttachments', () => {
 
   it('links to the download URL', async () => {
     render(<GroupEventAttachments project={project} group={group} />, {
-      router: screenshotRouter,
       organization,
-      deprecatedRouterMocks: true,
+      initialRouterConfig: screenshotRouterConfig,
     });
     await userEvent.click(await screen.findByLabelText('Actions'));
     expect(
@@ -126,9 +128,8 @@ describe('GroupEventAttachments', () => {
       statusCode: 500,
     });
     render(<GroupEventAttachments project={project} group={group} />, {
-      router,
       organization,
-      deprecatedRouterMocks: true,
+      initialRouterConfig,
     });
     expect(await screen.findByText(/error loading/i)).toBeInTheDocument();
   });
@@ -139,9 +140,8 @@ describe('GroupEventAttachments', () => {
       method: 'DELETE',
     });
     render(<GroupEventAttachments project={project} group={group} />, {
-      router,
       organization,
-      deprecatedRouterMocks: true,
+      initialRouterConfig,
     });
     renderGlobalModal();
 
@@ -169,13 +169,14 @@ describe('GroupEventAttachments', () => {
     render(<GroupEventAttachments project={project} group={group} />, {
       initialRouterConfig: {
         location: {
-          pathname: '/organizations/org-slug/issues/group-id/',
+          pathname: `/organizations/${organization.slug}/issues/${groupId}/attachments/`,
           query: {
             statsPeriod: '3d',
             query: 'user.email:leander.rodrigues@sentry.io',
             environment: ['staging'],
           },
         },
+        route: `/organizations/:orgId/issues/:groupId/attachments/`,
       },
       organization: {...organization, features: ['issue-details-streamline-enforce']},
     });
diff --git a/static/app/views/issueDetails/groupUptimeChecks.spec.tsx b/static/app/views/issueDetails/groupUptimeChecks.spec.tsx
@@ -3,10 +3,9 @@ import {EventFixture} from 'sentry-fixture/event';
 import {GroupFixture} from 'sentry-fixture/group';
 import {OrganizationFixture} from 'sentry-fixture/organization';
 import {ProjectFixture} from 'sentry-fixture/project';
-import {RouterFixture} from 'sentry-fixture/routerFixture';
 import {UptimeCheckFixture} from 'sentry-fixture/uptimeCheck';
 
-import {render, screen} from 'sentry-test/reactTestingLibrary';
+import {render, screen, type RouterConfig} from 'sentry-test/reactTestingLibrary';
 
 import GroupStore from 'sentry/stores/groupStore';
 import PageFiltersStore from 'sentry/stores/pageFiltersStore';
@@ -29,9 +28,12 @@ describe('GroupUptimeChecks', () => {
   });
   const organization = OrganizationFixture();
   const project = ProjectFixture();
-  const router = RouterFixture({
-    params: {groupId: group.id},
-  });
+  const initialRouterConfig: RouterConfig = {
+    location: {
+      pathname: `/organizations/${organization.slug}/issues/${group.id}/uptime-checks/`,
+    },
+    route: `/organizations/:orgId/issues/:groupId/uptime-checks/`,
+  };
 
   beforeEach(() => {
     GroupStore.init();
@@ -66,8 +68,7 @@ describe('GroupUptimeChecks', () => {
 
     render(<GroupUptimeChecks />, {
       organization,
-      router,
-      deprecatedRouterMocks: true,
+      initialRouterConfig,
     });
     expect(await screen.findByText('All Uptime Checks')).toBeInTheDocument();
     for (const column of ['Timestamp', 'Status', 'Duration', 'Trace', 'Region']) {
@@ -93,8 +94,7 @@ describe('GroupUptimeChecks', () => {
 
     render(<GroupUptimeChecks />, {
       organization,
-      router,
-      deprecatedRouterMocks: true,
+      initialRouterConfig,
     });
     expect(await screen.findByText('All Uptime Checks')).toBeInTheDocument();
     expect(screen.queryByText('No matching uptime checks found')).not.toBeInTheDocument();
@@ -129,8 +129,7 @@ describe('GroupUptimeChecks', () => {
 
     render(<GroupUptimeChecks />, {
       organization,
-      router,
-      deprecatedRouterMocks: true,
+      initialRouterConfig,
     });
     expect(await screen.findByText('All Uptime Checks')).toBeInTheDocument();
 
diff --git a/static/app/views/issueDetails/groupUserFeedback.spec.tsx b/static/app/views/issueDetails/groupUserFeedback.spec.tsx
@@ -1,9 +1,8 @@
 import {GroupFixture} from 'sentry-fixture/group';
 import {OrganizationFixture} from 'sentry-fixture/organization';
 import {ProjectFixture} from 'sentry-fixture/project';
-import {RouterFixture} from 'sentry-fixture/routerFixture';
 
-import {render, screen} from 'sentry-test/reactTestingLibrary';
+import {render, screen, type RouterConfig} from 'sentry-test/reactTestingLibrary';
 
 import ProjectsStore from 'sentry/stores/projectsStore';
 
@@ -13,9 +12,12 @@ describe('GroupUserFeedback', () => {
   const group = GroupFixture();
   const organization = OrganizationFixture();
   const project = ProjectFixture();
-  const router = RouterFixture({
-    params: {groupId: group.id},
-  });
+  const initialRouterConfig: RouterConfig = {
+    location: {
+      pathname: `/organizations/${organization.slug}/issues/${group.id}/`,
+    },
+    route: `/organizations/:orgId/issues/:groupId/`,
+  };
 
   beforeEach(() => {
     ProjectsStore.init();
@@ -35,8 +37,7 @@ describe('GroupUserFeedback', () => {
 
     render(<GroupUserFeedback />, {
       organization,
-      router,
-      deprecatedRouterMocks: true,
+      initialRouterConfig,
     });
     expect(
       await screen.findByRole('heading', {
@@ -74,8 +75,7 @@ describe('GroupUserFeedback', () => {
 
     render(<GroupUserFeedback />, {
       organization,
-      router,
-      deprecatedRouterMocks: true,
+      initialRouterConfig,
     });
     expect(await screen.findByText('Test User')).toBeInTheDocument();
     expect(await screen.findByText('custom comment')).toBeInTheDocument();
