fix(ui): fixed sidenav active state (#19875)

Author: robinrendle

src/sentry/static/sentry/app/views/settings/components/settingsLayout.tsx

@@ -168,8 +168,6 @@ const SidebarWrapper = styled('div')<{isVisible: boolean; offsetTop: number}>`
   width: ${p => p.theme.settings.sidebarWidth};
   background: ${p => p.theme.white};
   border-right: 1px solid ${p => p.theme.borderLight};
-  padding: ${space(4)};
-  padding-right: ${space(2)};
 
   @media (max-width: ${p => p.theme.breakpoints[0]}) {
     display: ${p => (p.isVisible ? 'block' : 'none')};

src/sentry/static/sentry/app/views/settings/components/settingsNavigation.tsx

@@ -2,6 +2,7 @@ import React from 'react';
 import * as Sentry from '@sentry/react';
 import styled from '@emotion/styled';
 
+import space from 'app/styles/space';
 import SettingsNavigationGroup from 'app/views/settings/components/settingsNavigationGroup';
 import {NavigationSection, NavigationProps} from 'app/views/settings/types';
 
@@ -58,11 +59,13 @@ class SettingsNavigation extends React.Component<Props> {
 const PositionStickyWrapper = styled('div')`
   @media (min-width: ${p => p.theme.breakpoints[0]}) {
     position: sticky;
-    top: 100px;
+    top: 70px;
     overflow: scroll;
-    height: calc(100vh - 98px);
+    height: calc(100vh - 70px);
     -ms-overflow-style: none;
     scrollbar-width: none;
+    padding: ${space(4)};
+    padding-right: ${space(2)};
 
     &::-webkit-scrollbar {
       display: none;