Fixes report_after_job_retries for retry: 0 (#1557)

* Fixes report_after_job_retries for retry: 0

* Updates CHANGELOG.md

* Updates changelog release to 4.7.1

Author: TAGraves

CHANGELOG.md

@@ -1,3 +1,9 @@
+## 4.7.1
+
+### Bug Fixes
+- Send events when report_after_job_retries is true and a job is configured with retry: 0 [#1557](https://github.com/getsentry/sentry-ruby/pull/1557)
+  - Fixes [#1556](https://github.com/getsentry/sentry-ruby/issues/1556)
+
 ## 4.7.0
 
 ### Features

sentry-sidekiq/lib/sentry/sidekiq/error_handler.rb

@@ -13,7 +13,7 @@ def call(ex, context)
 
         retry_option = context.dig(:job, "retry")
 
-        if Sentry.configuration.sidekiq.report_after_job_retries && retry_option.is_a?(Integer)
+        if Sentry.configuration.sidekiq.report_after_job_retries && retry_option.is_a?(Integer) && retry_option.positive?
           retry_count = context.dig(:job, "retry_count")
           if retry_count.nil? || retry_count < retry_option - 1
             return

sentry-sidekiq/spec/sentry/sidekiq_spec.rb

@@ -114,6 +114,12 @@
       expect(transport.events.count).to eq(1)
       expect(retry_set.count).to eq(1)
     end
+
+    it "doesn't affect jobs with zero retries" do
+      execute_worker(processor, ZeroRetryWorker)
+
+      expect(transport.events.count).to eq(1)
+    end
   end
 
   context "when tracing is enabled" do

sentry-sidekiq/spec/spec_helper.rb

@@ -143,6 +143,16 @@ def perform
   end
 end
 
+class ZeroRetryWorker
+  include Sidekiq::Worker
+
+  sidekiq_options retry: 0
+
+  def perform
+    1/0
+  end
+end
+
 def execute_worker(processor, klass)
   klass_options = klass.sidekiq_options_hash || {}
   options = {}