Merge pull request #319 from eagletmt/symbolized-keys

Fix event hash lookup

Author: nateberkopec

lib/raven/client.rb

@@ -32,7 +32,7 @@ def send(event)
         return
       end
 
-      Raven.logger.debug "Sending event #{event['id']} to Sentry"
+      Raven.logger.debug "Sending event #{event[:event_id]} to Sentry"
 
       content_type, encoded_data = encode(event)
 
@@ -73,7 +73,7 @@ def encode(event)
     end
 
     def get_log_message(event)
-      (event && event['message']) || '<no message value>'
+      (event && event[:message]) || '<no message value>'
     end
 
     def transport

spec/raven/integration_spec.rb

@@ -7,18 +7,21 @@
     stubs = Faraday::Adapter::Test::Stubs.new do |stub|
       stub.post('sentry/api/42/store/') { [200, {}, 'ok'] }
     end
+    io = StringIO.new
 
     Raven.configure do |config|
       config.server = 'http://12345:[email protected]/sentry/42'
       config.environments = ["test"]
       config.current_environment = "test"
       config.http_adapter = [:test, stubs]
+      config.logger = Logger.new(io)
     end
 
     Raven.capture_exception(build_exception)
 
     stubs.verify_stubbed_calls
 
+    expect(io.string).to match(/Sending event [0-9a-f]+ to Sentry$/)
   end
 
   example "posting an exception to a prefixed DSN" do
@@ -60,17 +63,20 @@
   end
 
   example "timed backoff should prevent sends" do
+    io = StringIO.new
     Raven.configure do |config|
       config.server = 'http://12345:[email protected]/sentry/42'
       config.environments = ["test"]
       config.current_environment = "test"
       config.http_adapter = [:test, nil]
+      config.logger = Logger.new(io)
     end
 
     expect_any_instance_of(Raven::Transports::HTTP).to receive(:send).exactly(1).times.and_raise(Faraday::Error::ConnectionFailed, "conn failed")
     expect { Raven.capture_exception(build_exception) }.not_to raise_error
 
     expect(Raven.logger).to receive(:error).exactly(1).times
     expect { Raven.capture_exception(build_exception) }.not_to raise_error
+    expect(io.string).to match(/Failed to submit event: ZeroDivisionError: divided by 0$/)
   end
 end