fix(strawberry): Remove autodetection, always use sync extension (#4984)

### Description

#### Problem

There are two ways to instrument strawberry-graphl apps: via a sync or
an async extension. We enable one or the other based on what web
framework is installed (async framework -> async extension, sync
framework -> sync extension). This auto-detection can be overridden via
an integration option.

At some point (SDK 2.0?), we added `StrawberryIntegration` to
auto-enabling integrations, which means the brittle auto-detection kicks
in as soon as someone has `strawberry-graphl` installed. This can lead
to issues, most notably when we auto-enable the async version of the
extension even though the user's Strawberry app is actually sync.

#### Options

1. Removing the auto-detection, always enabling the sync version if not
specified otherwise.
This way we'll never mistakenly enable async code in a sync app. We also
had a
[report](#3670 (comment))
at some point that the sync extension actually performs better than
async, so enabling sync by default shouldn't be a big problem in async
apps.
2. Removing `StrawberryIntegration` from auto-enabling integrations.
   Breaking change. People might just lose their traces and errors.
3. Improving the auto-detection.
   Best option, but out of ideas how to do this.

Went with 1), all things considered it's the least breaking change
(unless there's a way to do 3). Needs a big callout in the changelog
anyway though.

#### Issues
Closes #4980

#### Reminders
- Please add tests to validate your changes, and lint your code using
`tox -e linters`.
- Add GH Issue ID _&_ Linear ID (if applicable)
- PR title should use [conventional
commit](https://develop.sentry.dev/engineering-practices/commit-messages/#type)
style (`feat:`, `fix:`, `ref:`, `meta:`)
- For external contributors:
[CONTRIBUTING.md](https://github.com/getsentry/sentry-python/blob/master/CONTRIBUTING.md),
[Sentry SDK development docs](https://develop.sentry.dev/sdk/), [Discord
community](https://discord.gg/Ww9hbqr)

Author: sentrivana

sentry_sdk/integrations/strawberry.py

@@ -1,5 +1,6 @@
 import functools
 import hashlib
+import warnings
 from inspect import isawaitable
 
 import sentry_sdk
@@ -95,17 +96,19 @@ def _sentry_patched_schema_init(self, *args, **kwargs):
 
         extensions = kwargs.get("extensions") or []
 
+        should_use_async_extension = None  # type: Optional[bool]
         if integration.async_execution is not None:
             should_use_async_extension = integration.async_execution
         else:
             # try to figure it out ourselves
             should_use_async_extension = _guess_if_using_async(extensions)
 
-            logger.info(
-                "Assuming strawberry is running %s. If not, initialize it as StrawberryIntegration(async_execution=%s).",
-                "async" if should_use_async_extension else "sync",
-                "False" if should_use_async_extension else "True",
-            )
+            if should_use_async_extension is None:
+                warnings.warn(
+                    "Assuming strawberry is running sync. If not, initialize the integration as StrawberryIntegration(async_execution=True).",
+                    stacklevel=2,
+                )
+                should_use_async_extension = False
 
         # remove the built in strawberry sentry extension, if present
         extensions = [
@@ -382,12 +385,10 @@ def inner(event, hint):
 
 
 def _guess_if_using_async(extensions):
-    # type: (List[SchemaExtension]) -> bool
+    # type: (List[SchemaExtension]) -> Optional[bool]
     if StrawberrySentryAsyncExtension in extensions:
         return True
     elif StrawberrySentrySyncExtension in extensions:
         return False
 
-    return bool(
-        {"starlette", "starlite", "litestar", "fastapi"} & set(_get_installed_modules())
-    )
+    return None

tests/integrations/strawberry/test_strawberry.py

@@ -103,49 +103,24 @@ def create_app(schema):
 def test_async_execution_uses_async_extension(sentry_init):
     sentry_init(integrations=[StrawberryIntegration(async_execution=True)])
 
-    with mock.patch(
-        "sentry_sdk.integrations.strawberry._get_installed_modules",
-        return_value={"flask": "2.3.3"},
-    ):
-        # actual installed modules should not matter, the explicit option takes
-        # precedence
-        schema = strawberry.Schema(Query)
-        assert SentryAsyncExtension in schema.extensions
+    schema = strawberry.Schema(Query)
+    assert SentryAsyncExtension in schema.extensions
+    assert SentrySyncExtension not in schema.extensions
 
 
 def test_sync_execution_uses_sync_extension(sentry_init):
     sentry_init(integrations=[StrawberryIntegration(async_execution=False)])
 
-    with mock.patch(
-        "sentry_sdk.integrations.strawberry._get_installed_modules",
-        return_value={"fastapi": "0.103.1", "starlette": "0.27.0"},
-    ):
-        # actual installed modules should not matter, the explicit option takes
-        # precedence
-        schema = strawberry.Schema(Query)
-        assert SentrySyncExtension in schema.extensions
-
-
-def test_infer_execution_type_from_installed_packages_async(sentry_init):
-    sentry_init(integrations=[StrawberryIntegration()])
-
-    with mock.patch(
-        "sentry_sdk.integrations.strawberry._get_installed_modules",
-        return_value={"fastapi": "0.103.1", "starlette": "0.27.0"},
-    ):
-        schema = strawberry.Schema(Query)
-        assert SentryAsyncExtension in schema.extensions
+    schema = strawberry.Schema(Query)
+    assert SentrySyncExtension in schema.extensions
+    assert SentryAsyncExtension not in schema.extensions
 
 
-def test_infer_execution_type_from_installed_packages_sync(sentry_init):
+def test_use_sync_extension_if_not_specified(sentry_init):
     sentry_init(integrations=[StrawberryIntegration()])
-
-    with mock.patch(
-        "sentry_sdk.integrations.strawberry._get_installed_modules",
-        return_value={"flask": "2.3.3"},
-    ):
-        schema = strawberry.Schema(Query)
-        assert SentrySyncExtension in schema.extensions
+    schema = strawberry.Schema(Query)
+    assert SentrySyncExtension in schema.extensions
+    assert SentryAsyncExtension not in schema.extensions
 
 
 @pytest.mark.skipif(