Try to represent any logs attribute as string #1950
+71
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stayallive
commented
Oct 28, 2025
Comment on lines
90
to
96
| if ($value instanceof SerializableInterface) { | ||
| try { | ||
| return new self(JSON::encode($value->toSentry()), 'string'); | ||
| } catch (\Throwable $e) { | ||
| // Ignore the exception and continue trying other methods | ||
| } | ||
| } |
There was a problem hiding this comment.
Because we have it, I prefered this over the __toString or just raw JSON encode.
For safety we do ignore any errors to prevent crashing because serializing fails.
stayallive
commented
Oct 28, 2025
Comment on lines
+138
to
+139
| // Since we support almost any type, we use a resource to trigger the exception | ||
| Attribute::fromValue(fopen(__FILE__, 'r')); |
There was a problem hiding this comment.
It's now a challenge to find something we can't represent as an attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should try (harder) to represent values the user provides us as log attributes. So we now as last resort JSON encode the value which results in almost any value to be serialized and correctly logged. Also
nullvalues are now serialized as string instead of discarded.