wip

Author: cleptric

src/Tracing/PropagationContext.php

@@ -239,7 +239,6 @@ private static function parseTraceparentAndBaggage(string $traceparent, string $
 
         // Store the propagated trace sample rand or generate a new one
         if ($samplingContext->has('sample_rand')) {
-            // TODO check for 1e13 etc.
             $context->sampleRand = (float) $samplingContext->get('sample_rand');
         } else {
             if ($samplingContext->has('sample_rate') && $context->parentSampled !== null) {

src/Tracing/TransactionContext.php

@@ -205,15 +205,14 @@ private static function parseTraceAndBaggage(string $sentryTrace, string $baggag
 
         // Store the propagated trace sample rand or generate a new one
         if ($samplingContext->has('sample_rand')) {
-            // TODO check for 1e13 etc.
             $context->getMetadata()->setSampleRand((float) $samplingContext->get('sample_rand'));
         } else {
             if ($samplingContext->has('sample_rate') && $context->parentSampled !== null) {
                 if ($context->parentSampled === true) {
                     // [0, rate)
                     $context->getMetadata()->setSampleRand(round(mt_rand(0, mt_getrandmax() - 1) / mt_getrandmax() * (float) $samplingContext->get('sample_rate'), 6));
                 } else {
-                    // [rate, 1]
+                    // [rate, 1)
                     $context->getMetadata()->setSampleRand(round(mt_rand(0, mt_getrandmax() - 1) / mt_getrandmax() * (1 - (float) $samplingContext->get('sample_rate')) + (float) $samplingContext->get('sample-rate'), 6));
                 }
             } elseif ($context->parentSampled !== null) {