Skip to content

Commit b6dd2c7

Browse files
authored
ref: Remove performance clear entry calls (#2490)
* ref: Use `onresourcetimingbufferfull` * ref: Increase buffer *2 * chore: Changelog * fix: Remove callback
1 parent 5f1179d commit b6dd2c7

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44

55
- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott
66

7+
- [apm] ref: Remove performance clear entry calls (#2490)
8+
79
## 5.14.0
810

911
- [apm] feat: Add a simple heartbeat check, if activities don't change in 3 beats, finish the transaction (#2478)

packages/apm/src/integrations/tracing.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -603,14 +603,6 @@ export class Tracing implements Integration {
603603
addSpan(evaluation);
604604
}
605605

606-
// The Performance object has a limited buffer size, often 150 entries. At some point the buffer may overflow, in
607-
// which case we would not be able to use it to create/update spans. Therefore, after we have processed entries to
608-
// report to Sentry, we clear the buffer in an attempt to allow for more entries to be added in the future.
609-
// https://developer.mozilla.org/en-US/docs/Web/API/Performance
610-
logger.log('[Tracing] Clearing most performance marks');
611-
performance.clearMarks();
612-
performance.clearMeasures();
613-
performance.clearResourceTimings();
614606
Tracing._performanceCursor = Math.max(performance.getEntries().length - 1, 0);
615607

616608
// tslint:enable: no-unsafe-any

0 commit comments

Comments
 (0)