Fix playwright tests

Author: aliu39

dev-packages/browser-integration-tests/suites/integrations/featureFlags/launchdarkly/init.js renamed to dev-packages/browser-integration-tests/suites/integrations/featureFlags/launchdarkly/basic/init.js

@@ -27,13 +27,10 @@ const MockLaunchDarkly = {
   },
 };
 
-window.ldClient = undefined;
-
 window.initializeLD = () => {
-  window.ldClient = MockLaunchDarkly.initialize(
+  return MockLaunchDarkly.initialize(
     'example-client-id',
     { kind: 'user', key: 'example-context-key' },
     { inspectors: [buildLaunchDarklyFlagUsedHandler()] },
   );
-  return window.ldClient;
 };

dev-packages/browser-integration-tests/suites/integrations/featureFlags/launchdarkly/withScope/init.js

@@ -0,0 +1,36 @@
+import * as Sentry from '@sentry/browser';
+import { launchDarklyIntegration, buildLaunchDarklyFlagUsedHandler } from '@sentry/browser';
+
+window.Sentry = Sentry;
+window.sentryLDIntegration = launchDarklyIntegration();
+
+Sentry.init({
+  dsn: 'https://[email protected]/1337',
+  sampleRate: 1.0,
+  integrations: [window.sentryLDIntegration],
+});
+
+// Manually mocking this because LD only has mock test utils for the React SDK.
+// Also, no SDK has mock utils for FlagUsedHandler's.
+const MockLaunchDarkly = {
+  initialize(_clientId, context, options) {
+    const flagUsedHandler = (options && options.inspectors) ? options.inspectors[0].method : undefined;
+
+    return {
+      variation(key, defaultValue) {
+        if (flagUsedHandler) {
+          flagUsedHandler(key, { value: defaultValue }, context);
+        }
+        return defaultValue;
+      },
+    };
+  },
+};
+
+window.initializeLD = () => {
+  return MockLaunchDarkly.initialize(
+    'example-client-id',
+    { kind: 'user', key: 'example-context-key' },
+    { inspectors: [buildLaunchDarklyFlagUsedHandler()] },
+  );
+};

dev-packages/browser-integration-tests/suites/integrations/featureFlags/launchdarkly/withScope/test.ts

@@ -21,12 +21,9 @@ sentryTest('Flag evaluations in forked scopes are stored separately.', async ({
   const forkedReqPromise = waitForErrorRequest(page, event => !!event.tags && event.tags.isForked === true);
   const mainReqPromise = waitForErrorRequest(page, event => !!event.tags && event.tags.isForked === false);
 
-  const hasButton = await page.evaluate(() => {
+  await page.waitForFunction(() => {
     const Sentry = (window as any).Sentry;
-    const errorButton = document.querySelector('#error');
-    if (!(errorButton instanceof HTMLButtonElement)) {
-      return false;
-    }
+    const errorButton = document.querySelector('#error') as HTMLButtonElement;
     const ldClient = (window as any).initializeLD();
 
     ldClient.variation('shared', true);
@@ -35,7 +32,9 @@ sentryTest('Flag evaluations in forked scopes are stored separately.', async ({
       ldClient.variation('forked', true);
       ldClient.variation('shared', false);
       scope.setTag('isForked', true);
-      errorButton.click();
+      if (errorButton) {
+        errorButton.click();
+      }
     });
 
     ldClient.variation('main', true);
@@ -44,10 +43,6 @@ sentryTest('Flag evaluations in forked scopes are stored separately.', async ({
     return true;
   });
 
-  if (!hasButton) {
-    throw new Error('Expected template to have a button that throws an error')
-  }
-
   const forkedReq = await forkedReqPromise;
   const forkedEvent = envelopeRequestParser(forkedReq);