test: Streamline E2E test app names (#11828)

No need to have the `-app` suffix there.

Author: mydea

.github/workflows/build.yml

@@ -995,7 +995,7 @@ jobs:
           [
             'angular-17',
             'cloudflare-astro',
-            'node-express-app',
+            'node-express',
             'create-react-app',
             'create-next-app',
             'create-remix-app',
@@ -1015,13 +1015,12 @@ jobs:
             'sveltekit-2',
             'sveltekit-2-svelte-5',
             'generic-ts3.8',
-            'node-fastify-app',
-            # TODO(v8): Re-enable hapi tests
+            'node-fastify',
             'node-hapi',
-            'node-nestjs-app',
+            'node-nestjs',
             'node-exports-test-app',
-            'node-koa-app',
-            'node-connect-app',
+            'node-koa',
+            'node-connect',
             'vue-3',
             'webpack-4',
             'webpack-5'

dev-packages/e2e-tests/test-applications/node-connect-app/.npmrc renamed to dev-packages/e2e-tests/test-applications/node-connect/.npmrc

@@ -1,5 +1,5 @@
 {
-  "name": "node-connect-app",
+  "name": "node-connect",
   "version": "1.0.0",
   "private": true,
   "scripts": {

dev-packages/e2e-tests/test-applications/node-connect-app/package.json renamed to dev-packages/e2e-tests/test-applications/node-connect/package.json

@@ -2,5 +2,5 @@ import { startEventProxyServer } from '@sentry-internal/event-proxy-server';
 
 startEventProxyServer({
   port: 3031,
-  proxyServerName: 'node-koa-app',
+  proxyServerName: 'node-connect',
 });

dev-packages/e2e-tests/test-applications/node-connect-app/playwright.config.ts renamed to dev-packages/e2e-tests/test-applications/node-connect/playwright.config.ts

@@ -40,7 +40,7 @@ test('Sends exception to Sentry', async ({ baseURL }) => {
 });
 
 test('Sends correct error event', async ({ baseURL }) => {
-  const errorEventPromise = waitForError('node-connect-app', event => {
+  const errorEventPromise = waitForError('node-connect', event => {
     return !event.type && event.exception?.values?.[0]?.value === 'This is an exception';
   });
 

dev-packages/e2e-tests/test-applications/node-connect-app/src/app.ts renamed to dev-packages/e2e-tests/test-applications/node-connect/src/app.ts

@@ -8,7 +8,7 @@ const sentryTestProject = process.env.E2E_TEST_SENTRY_TEST_PROJECT;
 const EVENT_POLLING_TIMEOUT = 90_000;
 
 test('Sends an API route transaction', async ({ baseURL }) => {
-  const pageloadTransactionEventPromise = waitForTransaction('node-connect-app', transactionEvent => {
+  const pageloadTransactionEventPromise = waitForTransaction('node-connect', transactionEvent => {
     return (
       transactionEvent?.contexts?.trace?.op === 'http.server' &&
       transactionEvent?.transaction === 'GET /test-transaction'