sentry-cocoa 7.0.0-beta.0 crashes app if Mac Catalyst target

[3no-mark]

Environment

How do you use Sentry?
sentry.io

Which SDK and version?
sentry-cocoa 7.0.0-beta.0

Steps to Reproduce

Run iOS app with target Mac Catalyst, without Xcode debugger

Expected Result

app runs normally without crashing

Actual Result

app loads ok, window opens showing root vc. first click on window anywhere crashes app.

same code runs without issue with 6.2.1

[philipphofmann]

Thanks for reporting this issue @3no-mark. Can you please let us know how you include sentry-cocoa and which error you receive?

[philipphofmann]

I tried our sample project in this repo and another sample with CocoaPods. They both work fine with Mac Catalyst. I just checked with customer support and from your crash report I can see that our SentryCrashException Handler is crashing

Thread 5 Crashed:: SentryCrash Exception Handler (Primary)
0   org.cocoapods.Sentry          	0x000000010d03c7fe sentrycrash_get_async_caller_for_thread + 16 (SentryHook.c:31)
1   org.cocoapods.Sentry          	0x000000010d032e1e sentrycrashsc_initWithMachineContext + 69 (SentryCrashStackCursor_MachineContext.c:147)
2   org.cocoapods.Sentry          	0x000000010d0277a2 getStackCursor + 77 (SentryCrashReport.c:355) [inlined]
3   org.cocoapods.Sentry          	0x000000010d0277a2 writeThread + 166 (SentryCrashReport.c:1100)
4   org.cocoapods.Sentry          	0x000000010d028625 writeAllThreads + 200
5   org.cocoapods.Sentry          	0x000000010d02844b sentrycrashreport_writeStandardReport + 1842 (SentryCrashReport.c:1688)
6   org.cocoapods.Sentry          	0x000000010d016006 onCrash + 166 (SentryCrashC.c:107)
7   org.cocoapods.Sentry          	0x000000010d0218f2 sentrycrashcm_handleException + 117 (SentryCrashMonitor.c:241)
8   org.cocoapods.Sentry          	0x000000010d02322f handleExceptions + 722 (SentryCrashMonitor_MachException.c:338)
9   libsystem_pthread.dylib       	0x00007fff2050f950 _pthread_start + 224
10  libsystem_pthread.dylib       	0x00007fff2050b47b thread_start + 15

@Swatinem maybe some of your changes in SentryHook for the async stacktraces are causing this problem:

sentry-cocoa/Sources/SentryCrash/Recording/Tools/SentryHook.c

Lines 26 to 33 in e14fa82

	sentrycrash_get_async_caller_for_thread(SentryCrashThread thread)
	{
	const pthread_t pthread = pthread_from_mach_thread_np((thread_t)thread);
	void **tsd_slots = (void *)((uint8_t *)pthread + TSD_OFFSET);
	return (sentrycrash_async_backtrace_t *)__atomic_load_n(
	&tsd_slots[async_caller_key], __ATOMIC_SEQ_CST);
	}

From the crash report, I assume that you run this on an iMac with Intel and you include Sentry with CocoaPods and you use dynamic linking?

[3no-mark]

Mac is per screenshot below. Podfile from the problem build also below.

Your SentryCrashException Handler is not handling a crash from my code:

1. Same code runs without an issue when built with 6.2.1
2. Same code runs without issue under the Xcode debugger (using release build configuration) where, I assume, you are not tapping into the iOS uncaught exception handler.

Also note that the app loads ok and displays the root viewController's view in the app’s window. The crash occurs at the first click anywhere on the window.

Podfile.txt

[Swatinem]

Yes, this is absolutely an issue with the way I access thread locals across threads.

[philipphofmann]

Thanks @3no-mark for the extra info. I'm still not able to reproduce this on my machine with the same CocoaPods config and a release build. Can you maybe put together a sample project to help us reproduce this?

@Swatinem do you have any idea how to fix the issue with accessing thread locals across threads?

[Swatinem]

#1083 is using a different approach.
And we decided to disable this feature for now, and reintroduce it later behind a feature flag, so I will close this issue.

[philipphofmann]

For clarification @3no-mark, we think that #998 causes this problem. As mentioned by @Swatinem we disable this, for now, so your problem should be solved.

[3no-mark]

What release should I use to test/verify in my app?

[philipphofmann]

Please try with 7.0.0 and let us know if it works @3no-mark.

[3no-mark]

7.0.0 now works without crashing. Thank you @philipphofmann.