Skip to content

Allow to configure arbitrary headers passed in http calls. #4712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmajere opened this issue May 8, 2025 · 5 comments
Open

Allow to configure arbitrary headers passed in http calls. #4712

dmajere opened this issue May 8, 2025 · 5 comments

Comments

@dmajere
Copy link
Contributor

dmajere commented May 8, 2025

For sentry.io production infrastructure we plan to have some envoy route matching based on additional header.
Allow to configure arbitrary headers passed to upstreams.

@dmajere
Copy link
Contributor Author

dmajere commented May 8, 2025

Used host_header as example, added #4713

@Dav1dde
Copy link
Member

Dav1dde commented May 8, 2025

@dmajere Can envoy not just itself add that header? Istio can do it, so why do we need that in the application?

@dmajere
Copy link
Contributor Author

dmajere commented May 8, 2025

No, this header is used by envoy to pick correct upstream.

@Dav1dde
Copy link
Member

Dav1dde commented May 8, 2025

I don't understand this use case, if you want a host header, you should just configure the upstream URL correctly, especially the host header is the header which is controlled by the HTTP client framework, messing with that is not a good idea.

@dmajere
Copy link
Contributor Author

dmajere commented May 9, 2025

Here is the full explanation of a problem and solution we aim to
https://www.notion.so/sentry/US-Frontend-routing-1eb8b10e4b5d808fb561f335c15ad423?pvs=4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants