Skip to content

fix(schema): Preserve video fps constraints

8206d7b
Select commit
Loading
Failed to load commit list.
Merged

feat(ui-automation): Add rs/1 runtime automation parity #416

fix(schema): Preserve video fps constraints
8206d7b
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden: xcodebuildmcp-snapshot-fixture-review completed May 18, 2026 in 6m 58s

2 issues

xcodebuildmcp-snapshot-fixture-review: Found 2 issues (2 high)

High

Test expects all three test cases but `normalizeTestCases` still filters to failures-only - `src/snapshot-tests/__tests__/json-normalize.test.ts:29-36`

The updated .toEqual(...) asserts all three test cases are preserved, but normalizeTestCases in json-normalize.ts (line 170) still returns only failed items when any failure exists — this test will fail as written.

Test expects SDKROOT 'iphoneos' to pass through unchanged, but normalizer always replaces it with '<SDK_PATH>' - `src/snapshot-tests/__tests__/json-normalize.test.ts:156`

The expected output at line 156 says SDKROOT value 'iphoneos' is preserved after normalization, but normalizeBuildSettingsEntryValue in json-normalize.ts (line 102) replaces every SDKROOT value with '<SDK_PATH>' unconditionally — this test will fail as written.


⏱ 6m · 165.1k in / 10.9k out · $0.55

Annotations

Check failure on line 36 in src/snapshot-tests/__tests__/json-normalize.test.ts

See this annotation in the file changed.

@sentry-warden sentry-warden / warden: xcodebuildmcp-snapshot-fixture-review

Test expects all three test cases but `normalizeTestCases` still filters to failures-only

The updated `.toEqual(...)` asserts all three test cases are preserved, but `normalizeTestCases` in `json-normalize.ts` (line 170) still returns only failed items when any failure exists — this test will fail as written.

Check failure on line 156 in src/snapshot-tests/__tests__/json-normalize.test.ts

See this annotation in the file changed.

@sentry-warden sentry-warden / warden: xcodebuildmcp-snapshot-fixture-review

Test expects SDKROOT 'iphoneos' to pass through unchanged, but normalizer always replaces it with '&lt;SDK_PATH&gt;'

The expected output at line 156 says `SDKROOT` value `'iphoneos'` is preserved after normalization, but `normalizeBuildSettingsEntryValue` in `json-normalize.ts` (line 102) replaces every `SDKROOT` value with `'<SDK_PATH>'` unconditionally — this test will fail as written.