Skip to content

fix(schema): Preserve video fps constraints

8206d7b
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

feat(ui-automation): Add rs/1 runtime automation parity #416

fix(schema): Preserve video fps constraints
8206d7b
Select commit
Loading
Failed to load commit list.
GitHub Actions / warden: xcodebuildmcp-snapshot-fixture-review completed May 18, 2026 in 10m 45s

3 issues

xcodebuildmcp-snapshot-fixture-review: Found 3 issues (1 high, 2 medium)

High

Test expectation asserts all test cases are kept when failures exist, but normalizeTestCases still filters to failed-only - `src/snapshot-tests/__tests__/json-normalize.test.ts:29-36`

The expected output now includes both passed and failed test cases, but normalizeTestCases in json-normalize.ts still returns failed (only failed items) when failed.length > 0 — making this test assertion wrong and the test will fail.

Medium

Test expects SDKROOT 'iphoneos' to pass through unchanged, but normalizer unconditionally replaces it with '<SDK_PATH>' - `src/snapshot-tests/__tests__/json-normalize.test.ts:156`

The expected output at line 156 sets { key: 'SDKROOT', value: 'iphoneos' }, but normalizeBuildSettingsEntryValue in json-normalize.ts line 102 unconditionally returns '<SDK_PATH>' for any SDKROOT key — this test will fail as written.

CLI JSON fixtures absent for swipe--error-not-actionable, type-text--error-not-actionable, and wait-for-ui--success while MCP JSON and CLI text fixtures exist

Three new ui-automation scenarios have CLI text fixtures and MCP JSON fixtures but no corresponding CLI JSON fixtures, violating the requirement that MCP, CLI, and JSON fixture updates stay aligned.


⏱ 9m 2s · 248.8k in / 22.4k out · $1.09

Annotations

Check failure on line 36 in src/snapshot-tests/__tests__/json-normalize.test.ts

See this annotation in the file changed.

@github-actions github-actions / warden: xcodebuildmcp-snapshot-fixture-review

Test expectation asserts all test cases are kept when failures exist, but normalizeTestCases still filters to failed-only

The expected output now includes both passed and failed test cases, but `normalizeTestCases` in `json-normalize.ts` still returns `failed` (only failed items) when `failed.length > 0` — making this test assertion wrong and the test will fail.

Check warning on line 156 in src/snapshot-tests/__tests__/json-normalize.test.ts

See this annotation in the file changed.

@github-actions github-actions / warden: xcodebuildmcp-snapshot-fixture-review

Test expects SDKROOT 'iphoneos' to pass through unchanged, but normalizer unconditionally replaces it with '&lt;SDK_PATH&gt;'

The expected output at line 156 sets `{ key: 'SDKROOT', value: 'iphoneos' }`, but `normalizeBuildSettingsEntryValue` in `json-normalize.ts` line 102 unconditionally returns `'<SDK_PATH>'` for any SDKROOT key — this test will fail as written.