Skip to content

Commit c8d99b7

Browse files
authoredMar 29, 2023
Merge pull request #2665 from carolynvs/schema-fixes
Updates to bundle schema v1.0.1
2 parents 763c537 + ec4e3cc commit c8d99b7

File tree

3 files changed

+20
-5
lines changed

3 files changed

+20
-5
lines changed
 

‎pkg/porter/testdata/schema.json

+6-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"type": "array"
2424
},
2525
"bundle": {
26-
"description": "The defintion of a bundle reference",
26+
"description": "The definition of a bundle reference",
2727
"properties": {
2828
"reference": {
2929
"description": "The full bundle reference for the dependency in the format REGISTRY/NAME:TAG",
@@ -99,6 +99,10 @@
9999
"type": "string"
100100
},
101101
"parameters": {
102+
"additionalProperties": {
103+
"type": "string"
104+
},
105+
"description": "Map of parameter names to a parameter source, such as bundle.parameters.PARAM, bundle.dependencies.DEP.outputs.OUTPUT, or bundle.credentials.CRED",
102106
"type": "object"
103107
}
104108
},
@@ -774,6 +778,7 @@
774778
"type": "string"
775779
},
776780
"schemaVersion": {
781+
"default": "1.0.1",
777782
"description": "The version of the schema used in this file",
778783
"type": "string"
779784
},

‎pkg/schema/manifest.schema.json

+8-3
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,11 @@
174174
"$ref": "#/definitions/bundle"
175175
},
176176
"parameters": {
177-
"type": "object"
177+
"description": "Map of parameter names to a parameter source, such as bundle.parameters.PARAM, bundle.dependencies.DEP.outputs.OUTPUT, or bundle.credentials.CRED",
178+
"type": "object",
179+
"additionalProperties": {
180+
"type": "string"
181+
}
178182
}
179183
},
180184
"required": [
@@ -184,7 +188,7 @@
184188
"type": "object"
185189
},
186190
"bundle": {
187-
"description": "The defintion of a bundle reference",
191+
"description": "The definition of a bundle reference",
188192
"properties": {
189193
"reference": {
190194
"description": "The full bundle reference for the dependency in the format REGISTRY/NAME:TAG",
@@ -291,7 +295,8 @@
291295
},
292296
"schemaVersion": {
293297
"description": "The version of the schema used in this file",
294-
"type": "string"
298+
"type": "string",
299+
"default": "1.0.1"
295300
},
296301
"credentials": {
297302
"type": "array",

‎tests/integration/testdata/schema/schema.json

+6-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"type": "array"
2424
},
2525
"bundle": {
26-
"description": "The defintion of a bundle reference",
26+
"description": "The definition of a bundle reference",
2727
"properties": {
2828
"reference": {
2929
"description": "The full bundle reference for the dependency in the format REGISTRY/NAME:TAG",
@@ -99,6 +99,10 @@
9999
"type": "string"
100100
},
101101
"parameters": {
102+
"additionalProperties": {
103+
"type": "string"
104+
},
105+
"description": "Map of parameter names to a parameter source, such as bundle.parameters.PARAM, bundle.dependencies.DEP.outputs.OUTPUT, or bundle.credentials.CRED",
102106
"type": "object"
103107
}
104108
},
@@ -774,6 +778,7 @@
774778
"type": "string"
775779
},
776780
"schemaVersion": {
781+
"default": "1.0.1",
777782
"description": "The version of the schema used in this file",
778783
"type": "string"
779784
},

0 commit comments

Comments
 (0)
Please sign in to comment.