Failure to use http/https for homepage.href handling

[sandman98321]

Description

As I've been (sloooowly) moved toward using discovery labels, I've been sometimes seeing a weird issue where some of my homepage.href= lines had been hard linking to [local ip]:[port]/[proxy url] (so, hovering over the link from homepage shows "192.168.1.121:3000/homepage.[mynetworkname].net")

I figured out that my failure to use https:// or http:// before my URL in the homepage.href= field was causing the problem.

I'm running stacks in Portainer, so I can't conclusively state that this is a Homepage vs. Docker vs. Portainer issue.

I'd like to suggest either adding a note to the documentation that including http/https when using homepage.href is required, or find a way to throw an error that might give useful feedback.

homepage version

v1.1.1.1

Installation method

Docker

Configuration

No response

Container Logs

No response

Browser Logs

No response

Troubleshooting

Problem is solved, this is a doc/error handling suggestion.

[shamoon]

I mean, Im not aware of this being a point of confusion in general, I think youre the first person to raise it. The docs show a URL, including a protocol, as noted, not a host or domain or something like that.

[sandman98321]

I think when it's a configuration issue, I expect to see an error of some sort if it's broken (I'm plenty used to "it just won't render" meaning "I effed up the YAML somewhere" haha), rather than me staring at it and saying "it's wrong, what the heck is wrong, when 3 out of 4 of these work just fine".

I also get that not seeing anyone else raise this as an issue makes it a me problem, and I'm good if you do nothing with it. If someone else like me has the problem down the line, at least now they'll hopefully find this and be able to fix it.

[shamoon]

Yea, unlike e.g. a form on the web we dont (and wont) validate content like this. Yaml errors like formatting etc are one thing but this is more like input validation which is going to be too complex / cumbersome to do in general. If there is an issue here for a bunch of people then we could potentially add something specifically for the url here.

[github-actions[bot]]

This discussion has been automatically closed due to lack of community support. See our contributing guidelines for more details.

[github-actions[bot]]

This discussion has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.