-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boolean difference causes panic: segment not found
#1193
Comments
Does it work with |
Yes this test passes with |
Right, it can still happen, but it does make sense to use higher than input precision for computation. Not an elegant solution, but worth considering. |
Understood, we'll change our codebase to use f64. For some context, we're currently using f32 only because we're generating vertex buffer data that gets fed into WebGL, and out of laziness we're avoiding a f64 => f32 conversion step. |
Update: unfortunately we can still easily reproduce a similar panic after changing our codebase to use 64-bit precision. |
I just merged #1234 which replaces our BoolOps implementation with one backed by the i_overlay crate. This should resolve the issue you're seeing. Let us know if it recurs. You can use it now if you use the unreleased |
In this new unit test, a panic is provoked by calling
difference
. The error message looks like this:Here's the new regression test:
prideout@632d152
This might be related to #1104?
At Arcol we're quite vested in Geo, and we ran into this with one of our customers.
The text was updated successfully, but these errors were encountered: