Improve typing for react states (#967)

* Improve typing for react states

* Edit according to comments

Author: gaolinai8888

packages/base/src/dialogs/ProcessingFormDialog.tsx

@@ -45,11 +45,11 @@ const ProcessingFormWrapper: React.FC<IProcessingFormWrapperProps> = props => {
     props.formErrorSignalPromise?.promise,
   ]).then(([ok, formChanged]) => {
     okSignal.current = ok;
-    formErrorSignal.current = formChanged;
+    formErrorSignal.current = formChanged || undefined;
     setReady(true);
   });
 
-  let FormComponent;
+  let FormComponent: React.ComponentType<any>;
   switch (props.processingType) {
     case 'Dissolve':
       FormComponent = DissolveForm;
@@ -65,7 +65,6 @@ const ProcessingFormWrapper: React.FC<IProcessingFormWrapperProps> = props => {
         filePath={props.model.filePath}
         model={props.model}
         ok={okSignal.current}
-        cancel={props.cancel}
         sourceData={props.sourceData}
         schema={props.schema}
         syncData={props.syncData}
@@ -183,5 +182,5 @@ export class ProcessingFormDialog extends Dialog<IDict> {
     }
   }
 
-  private okSignal: Signal<Dialog<any>, number>;
+  private okSignal: Signal<Dialog<IDict>, number>;
 }

packages/base/src/dialogs/symbology/symbologyDialog.tsx

@@ -46,7 +46,8 @@ const SymbologyDialog: React.FC<ISymbologyDialogProps> = ({
   cancel,
 }) => {
   const [selectedLayer, setSelectedLayer] = useState<string | null>(null);
-  const [componentToRender, setComponentToRender] = useState<any>(null);
+  const [componentToRender, setComponentToRender] =
+    useState<JSX.Element | null>(null);
 
   let LayerSymbology: React.JSX.Element;