* Added subtrait for TimerCallback to address clippy error

Author: imdexsam

rclrs/src/node.rs

@@ -17,7 +17,7 @@ use crate::{
     rcl_bindings::*, Client, ClientBase, Clock, Context, ContextHandle, GuardCondition,
     ParameterBuilder, ParameterInterface, ParameterVariant, Parameters, Publisher, QoSProfile,
     RclrsError, Service, ServiceBase, Subscription, SubscriptionBase, SubscriptionCallback,
-    TimeSource, Timer, TimerBase, ENTITY_LIFECYCLE_MUTEX,
+    TimeSource, Timer, TimerBase, TimerCallback, ENTITY_LIFECYCLE_MUTEX,
 };
 
 // SAFETY: The functions accessing this type, including drop(), shouldn't care about the thread
@@ -336,7 +336,7 @@ impl Node {
         callback: F,
     ) -> Result<Arc<Mutex<Timer>>, RclrsError>
     where
-        F: FnMut(&mut Timer) + 'static + Send + Sync,
+        F: TimerCallback + 'static,
     {
         let timer = Arc::new(Mutex::new(Timer::new_with_context_handle(
             Arc::clone(&self.handle.context_handle),

rclrs/src/timer.rs

@@ -15,6 +15,12 @@ use std::{
     time::Duration,
 };
 
+/// A trait for the callback function of a timer.
+pub trait TimerCallback: FnMut(&mut Timer) + Send + Sync {}
+
+// Blanket implementation of TimerCallback for all types that implement the necessary traits.
+impl<T: FnMut(&mut Timer) + Send + Sync> TimerCallback for T {}
+
 // SAFETY: The functions accessing this type, including drop(), shouldn't care
 // about the thread they are running in (partly because they're protected by mutex).
 // Therefore, this type can be safely sent to another thread.
@@ -76,7 +82,7 @@ pub trait TimerBase: Send + Sync {
 /// [5]: crate::Timer::execute
 /// [6]: crate::WaitSet
 pub struct Timer {
-    callback: Arc<Mutex<dyn FnMut(&mut Timer) + Send + Sync>>,
+    callback: Arc<Mutex<dyn TimerCallback>>,
     handle: TimerHandle,
 }
 
@@ -96,7 +102,7 @@ impl Timer {
         callback: F,
     ) -> Result<Self, RclrsError>
     where
-        F: FnMut(&mut Timer) + 'static + Send + Sync,
+        F: TimerCallback + 'static,
     {
         Timer::new_with_context_handle(Arc::clone(&context.handle), clock, period, callback)
     }
@@ -109,7 +115,7 @@ impl Timer {
         callback: F,
     ) -> Result<Self, RclrsError>
     where
-        F: FnMut(&mut Timer) + 'static + Send + Sync,
+        F: TimerCallback + 'static,
     {
         let callback = Arc::new(Mutex::new(callback));