Move damage sequence check before OnEnemyHit emit and attack mods (#2551)

Co-authored-by: Charlie Zheng <charlie.x.3000@gmail.com>

Author: shizukayuki

pkg/enemy/attack.go

@@ -24,8 +24,13 @@ var particleIDToElement = []attributes.Element{
 }
 
 func (e *Enemy) HandleAttack(atk *info.AttackEvent) float64 {
-	// at this point attack will land
-	e.Core.Combat.Events.Emit(event.OnEnemyHit, e, atk)
+	grpMult := 1.0
+	if !atk.Info.SourceIsSim {
+		grpMult = e.GroupTagDamageMult(atk.Info.ICDTag, atk.Info.ICDGroup, atk.Info.ActorIndex)
+	}
+	if grpMult > 0 {
+		e.Core.Combat.Events.Emit(event.OnEnemyHit, e, atk)
+	}
 
 	var amp string
 	var cata string
@@ -52,7 +57,7 @@ func (e *Enemy) HandleAttack(atk *info.AttackEvent) float64 {
 		evt.Write("pre_damage_mods", preDmgModDebug)
 	}
 
-	dmg, crit = e.attack(atk, evt)
+	dmg, crit = e.attack(atk, evt, grpMult)
 
 	// delay damage event to end of the frame
 	e.Core.Combat.Tasks.Add(func() {
@@ -84,7 +89,7 @@ func (e *Enemy) HandleAttack(atk *info.AttackEvent) float64 {
 	return dmg
 }
 
-func (e *Enemy) attack(atk *info.AttackEvent, evt glog.Event) (float64, bool) {
+func (e *Enemy) attack(atk *info.AttackEvent, evt glog.Event, grpMult float64) (float64, bool) {
 	// if target is frozen prior to attack landing, set impulse to 0
 	// let the break freeze attack to trigger actual impulse
 	if e.GetAuraDurability(info.ReactionModKeyFrozen) > info.ZeroDur {
@@ -135,7 +140,7 @@ func (e *Enemy) attack(atk *info.AttackEvent, evt glog.Event) (float64, bool) {
 		}
 	}
 
-	damage, isCrit := e.calc(atk, evt)
+	damage, isCrit := e.calc(atk, evt, grpMult)
 
 	// check for hitlag
 	if e.Core.Combat.EnableHitlag {

pkg/enemy/damage.go

@@ -7,12 +7,12 @@ import (
 	"github.com/genshinsim/gcsim/pkg/core/info"
 )
 
-func (e *Enemy) calc(atk *info.AttackEvent, evt glog.Event) (float64, bool) {
+func (e *Enemy) calc(atk *info.AttackEvent, evt glog.Event, grpMult float64) (float64, bool) {
 	var isCrit bool
 
 	if atk.Info.AttackTag == attacks.AttackTagDirectLunarCharged ||
 		atk.Info.AttackTag == attacks.AttackTagDirectLunarBloom {
-		e.calcDirectLunar(atk, evt)
+		e.calcDirectLunar(atk, evt, grpMult)
 	}
 
 	elePer := 0.0
@@ -112,11 +112,7 @@ func (e *Enemy) calc(atk *info.AttackEvent, evt glog.Event) (float64, bool) {
 	}
 
 	// reduce damage by damage group
-	x := 1.0
-	if !atk.Info.SourceIsSim {
-		x = e.GroupTagDamageMult(atk.Info.ICDTag, atk.Info.ICDGroup, atk.Info.ActorIndex)
-		damage *= x
-	}
+	damage *= grpMult
 
 	elevation := atk.Info.Elevation
 	damage *= 1 + elevation
@@ -128,7 +124,7 @@ func (e *Enemy) calc(atk *info.AttackEvent, evt glog.Event) (float64, bool) {
 			atk.Info.ActorIndex,
 		).
 			Write("src_frame", atk.SourceFrame).
-			Write("damage_grp_mult", x).
+			Write("damage_grp_mult", grpMult).
 			Write("damage", damage).
 			Write("abil", atk.Info.Abil).
 			Write("talent", atk.Info.Mult).
@@ -184,7 +180,7 @@ func (e *Enemy) calc(atk *info.AttackEvent, evt glog.Event) (float64, bool) {
 	return damage, isCrit
 }
 
-func (e *Enemy) calcDirectLunar(atk *info.AttackEvent, evt glog.Event) (float64, bool) {
+func (e *Enemy) calcDirectLunar(atk *info.AttackEvent, evt glog.Event, grpMult float64) (float64, bool) {
 	var isCrit bool
 
 	// no DMG% for direct lunar damage
@@ -246,11 +242,7 @@ func (e *Enemy) calcDirectLunar(atk *info.AttackEvent, evt glog.Event) (float64,
 	damage *= resmod
 
 	// reduce damage by damage group
-	x := 1.0
-	if !atk.Info.SourceIsSim {
-		x = e.GroupTagDamageMult(atk.Info.ICDTag, atk.Info.ICDGroup, atk.Info.ActorIndex)
-		damage *= x
-	}
+	damage *= grpMult
 
 	elevation := atk.Info.Elevation
 	damage *= 1 + elevation
@@ -281,7 +273,7 @@ func (e *Enemy) calcDirectLunar(atk *info.AttackEvent, evt glog.Event) (float64,
 			atk.Info.ActorIndex,
 		).
 			Write("src_frame", atk.SourceFrame).
-			Write("damage_grp_mult", x).
+			Write("damage_grp_mult", grpMult).
 			Write("damage", damage).
 			Write("abil", atk.Info.Abil).
 			Write("talent", atk.Info.Mult).