Skip to content

Commit 166436a

Browse files
authored
contributing: update some guidelines, short waiting time for other maintainers reviews
1 parent 212c509 commit 166436a

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

website/contributing.md

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,16 +31,19 @@ These base guidelines (if not specified otherwise) apply to every repository und
3131

3232
- Tests and pipelines must pass. If they failed because of something unrelated to the PR (e.g. a link died in the meantime), mention it in the PR thread.
3333
- If the solution is "sub-optimal" (but still better than the actual implementation) and there are clear possible improvements, mention them and try to collaborate with the contributor, but ultimately prefer merging something sub-optimal than keeping the content stale/inactive. An issue can be opened (or kept opened) to report this situation.
34+
- If there's an ongoing conversation/discussion on a PR/thread, let it continue. Don't abruptly merge unless there's a clear consensus among the core maintainers (and approvals).
35+
- Respect the requests from other maintainers for additional time if they ask for it.
3436

35-
For disruptive PRs:
37+
38+
For disruptive (e.g. major and/or breaking changes) PRs:
3639

3740
- Wait for 2\* maintainers approval
3841
- Every week of inactivity/staleness, ping maintainers
39-
- After **5** weeks from last activity, PR is merge-able with only 1 maintainer approval
42+
- After **2** weeks from last approval, PR is merge-able with only 1 maintainer approval
4043

4144
For non-disruptive PRs:
4245

43-
- Wait for 1 maintainer approval and merge it after 5 days
46+
- Wait for 1 maintainer approval
4447
- If a maintainer wants to put a veto and to make the PR wait for his/her input after the mentioned period, the "veto" label can be used
4548

4649
\*if there are at least 2 active maintainers, otherwise 1.

0 commit comments

Comments
 (0)