feat: add support for EUR currency and enhance exchange rate handling across components

Author: gazarrillo

functions/lib/exchangeRates.js

@@ -9,8 +9,8 @@ if (!admin.apps.length) {
   admin.initializeApp();
 }
 
-/** Scrape the BCV official USD rate directly from bcv.org.ve */
-async function scrapeBCVRate(): Promise<number | null> {
+/** Scrape the BCV official USD and EUR rates directly from bcv.org.ve */
+async function scrapeBCVRates(): Promise<{ usd: number; eur: number } | null> {
   try {
     const httpsAgent = new https.Agent({ rejectUnauthorized: false });
     const response = await axios.get('https://www.bcv.org.ve/', {
@@ -24,22 +24,34 @@ async function scrapeBCVRate(): Promise<number | null> {
     });
 
     const $ = cheerio.load(response.data);
-    const rateText = $('#dolar .centrado strong').text().trim();
 
-    if (!rateText) {
-      logger.error('Could not find USD rate on BCV website');
-      return null;
+    function parseRate(selector: string, label: string): number | null {
+      const text = $(selector).text().trim();
+      if (!text) {
+        logger.error(`Could not find ${label} rate on BCV website`);
+        return null;
+      }
+      const rate = parseFloat(text.replace(',', '.'));
+      if (isNaN(rate) || rate <= 0) {
+        logger.error(`Failed to parse BCV ${label} rate: "${text}"`);
+        return null;
+      }
+      return rate;
     }
 
-    // BCV uses comma as decimal separator, e.g. "459,4525"
-    const rate = parseFloat(rateText.replace(',', '.'));
-    if (isNaN(rate) || rate <= 0) {
-      logger.error(`Failed to parse BCV rate: "${rateText}"`);
-      return null;
+    const usd = parseRate('#dolar .centrado strong', 'USD');
+    const eur = parseRate('#euro .centrado strong', 'EUR');
+
+    if (!usd) return null;
+
+    // EUR is optional — USD is required
+    if (eur) {
+      logger.info(`Scraped BCV rates: 1 USD = ${usd} VES, 1 EUR = ${eur} VES`);
+      return { usd, eur };
     }
 
-    logger.info(`Scraped BCV rate: 1 USD = ${rate} VES`);
-    return rate;
+    logger.warn('EUR rate not found, using USD-derived estimate');
+    return { usd, eur: usd * 1.08 };
   } catch (error) {
     logger.error('Error scraping BCV website:', error);
     return null;
@@ -55,21 +67,21 @@ export const fetchExchangeRates = onSchedule(
   async () => {
     logger.info('Fetching BCV exchange rates...');
 
-    let usdToVes = await scrapeBCVRate();
-    let source = 'bcv.org.ve (scrape)';
+    const bcvRates = await scrapeBCVRates();
+    const source = 'bcv.org.ve (scrape)';
 
-    if (!usdToVes) {
-      logger.error('BCV scrape failed — no rate obtained');
+    if (!bcvRates) {
+      logger.error('BCV scrape failed — no rates obtained');
       return;
     }
 
     const db = admin.firestore();
     const now = admin.firestore.Timestamp.now();
 
     await db.collection('exchangeRates').add({
-      rates: { USD: usdToVes },
+      rates: { USD: bcvRates.usd, EUR: bcvRates.eur },
       source,
       recordedAt: now,
     });
-    logger.info(`Stored BCV rate: 1 USD = ${usdToVes} VES (source: ${source})`);
+    logger.info(`Stored BCV rates: 1 USD = ${bcvRates.usd} VES, 1 EUR = ${bcvRates.eur} VES (source: ${source})`);
   });

functions/lib/exchangeRates.js.map

@@ -3,6 +3,7 @@
     "module": "commonjs",
     "noImplicitReturns": true,
     "noUnusedLocals": false,
+    "rootDir": "src",
     "outDir": "lib",
     "sourceMap": true,
     "strict": true,