Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't clobber generic global names like BilinearForm, SymplecticForm, SymmetricBilinearForm, QuadraticForm #86

Open
fingolfin opened this issue Nov 29, 2021 · 0 comments

Comments

@fingolfin
Copy link
Member

We currently are clobbering a bunch of identifiers that other packages (in particular the forms package) may also want to use for their own purposes. In particular:

DeclareGlobalFunction("BilinearForm");
DeclareGlobalFunction("SymplecticForm");
DeclareGlobalFunction("SymmetricBilinearForm");
DeclareGlobalFunction("QuadraticForm"); # see PR #85 

I have not yet looked closely what they do; but depending on that, we should consider one of these options:

  1. if they are useful for anyone dealing with forms, perhaps migrate them to the forms package
  2. if they are purely internal tools, rename them to e.g. CM_BilinearForms (where CM is short for ClassicalMaximals)
  3. or turn these global functions into operations, then other packages can install alternative methods for them
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant