Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review older testfiles according to the new checklist #29

Open
13 tasks
danielrademacher opened this issue Sep 29, 2021 · 1 comment
Open
13 tasks

Review older testfiles according to the new checklist #29

danielrademacher opened this issue Sep 29, 2021 · 1 comment
Assignees
@JulianBehrmann

Comments

@danielrademacher
Copy link
Collaborator

danielrademacher commented Sep 29, 2021 •
edited by ssiccha
Loading

The following testfiles should be checked according to the checklist from Issue #27:
(update by @ssiccha: I updated the list. Also instead of #27 one can have a look at the file .github/pull_request_template.md)

  • quick
    • Forms.tst
    • Utils.tst
  • standard
    • ClassicalMaximals.tst
    • ClassicalNormalizerMatrixGroups.tst
    • ExtraspecialNormalizerMatrixGroups.tst
    • ImprimitiveMatrixGroups.tst
    • ReducibleMatrixGroups.tst
    • SemilinearMatrixGroups.tst
    • SubfieldMatrixGroups.tst
    • TensorInducedMatrixGroups.tst
    • TensorProductMatrixGroups.tst

In addition, it should be checked which functions have no tests yet. In this regard, Issue #15 should be noted or expanded.
@danielrademacher danielrademacher changed the title Check the following files according to #26 Check the following testfiles according to #26 Sep 29, 2021
@danielrademacher danielrademacher changed the title Check the following testfiles according to #26 Check the following testfiles according to Issue #26 Sep 29, 2021
@danielrademacher danielrademacher changed the title Check the following testfiles according to Issue #26 Check the following testfiles according to issue #26 Sep 29, 2021
@danielrademacher danielrademacher changed the title Check the following testfiles according to issue #26 Check the following testfiles according to Issue #26 Sep 29, 2021
@danielrademacher danielrademacher changed the title Check the following testfiles according to Issue #26 Check the following testfiles according to Issue #27 Sep 29, 2021
@ssiccha ssiccha changed the title Check the following testfiles according to Issue #27 Review some testfiles according to the new checklist Oct 5, 2021
@ssiccha ssiccha changed the title Review some testfiles according to the new checklist Review older testfiles according to the new checklist Oct 5, 2021
@ssiccha ssiccha assigned ssiccha and unassigned ssiccha Nov 17, 2021
@ssiccha
Copy link
Collaborator

ssiccha commented Nov 17, 2021

I think @JulianBehrmann can start by looking into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JulianBehrmann JulianBehrmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ssiccha @danielrademacher @JulianBehrmann