refactor: introduce display package for improved package listing and output management

Author: gambitier

cmd/list.go

@@ -2,12 +2,11 @@ package cmd
 
 import (
 	"fmt"
-	"os"
 	"strings"
 
 	"github.com/fatih/color"
 	"github.com/gambitier/tag-manager/pkg/discovery"
-	"github.com/olekukonko/tablewriter"
+	"github.com/gambitier/tag-manager/pkg/display"
 	"github.com/spf13/cobra"
 )
 
@@ -40,44 +39,13 @@ func runList(cmd *cobra.Command, args []string) error {
 		return nil
 	}
 
-	color.Cyan("Discovered %d Go packages:", len(packages))
-	color.White("Search paths: %s", strings.Join(searchPaths, ", "))
-	color.White("")
-
-	// Create table with modern API
-	table := tablewriter.NewWriter(os.Stdout)
-
+	// Determine display mode
+	mode := display.Compact
 	if verbose {
-		table.Header("#", "Module", "Package", "Go Version", "GitHub", "Latest Tag")
-	} else {
-		table.Header("#", "Package", "Latest Tag")
-	}
-
-	// Add rows
-	for i, pkg := range packages {
-		// Handle empty values
-		goVersion := pkg.GoVersion
-		if goVersion == "" {
-			goVersion = "-"
-		}
-
-		github := pkg.GitHubRepo
-		if github == "" {
-			github = "-"
-		}
-
-		latestTag := pkg.LatestTag
-		if latestTag == "" {
-			latestTag = "(no tags)"
-		}
-
-		if verbose {
-			table.Append(fmt.Sprintf("%d", i+1), pkg.ModulePath, pkg.PackageName, goVersion, github, latestTag)
-		} else {
-			table.Append(fmt.Sprintf("%d", i+1), pkg.PackageName, latestTag)
-		}
+		mode = display.Verbose
 	}
 
-	table.Render()
+	// Show package list with header
+	display.ShowPackageListWithHeader(packages, mode, searchPaths)
 	return nil
 }

cmd/update.go

@@ -8,6 +8,7 @@ import (
 	"github.com/fatih/color"
 	"github.com/gambitier/tag-manager/pkg/config"
 	"github.com/gambitier/tag-manager/pkg/discovery"
+	"github.com/gambitier/tag-manager/pkg/display"
 	"github.com/gambitier/tag-manager/pkg/interactive"
 	"github.com/gambitier/tag-manager/pkg/tagutils"
 	"github.com/spf13/cobra"
@@ -45,6 +46,11 @@ func runUpdate(cmd *cobra.Command, args []string) error {
 		return nil
 	}
 
+	// Display available packages
+	color.Cyan("Available packages:")
+	display.ShowPackageList(packages, display.Compact)
+	color.White("")
+
 	// Let user select a package
 	selectedPackage, err := interactive.SelectPackage(packages)
 	if err != nil {

pkg/display/display.go

@@ -0,0 +1,74 @@
+package display
+
+import (
+	"fmt"
+	"os"
+	"strings"
+
+	"github.com/fatih/color"
+	"github.com/gambitier/tag-manager/pkg/discovery"
+	"github.com/olekukonko/tablewriter"
+)
+
+// DisplayMode represents the display mode for package lists
+type DisplayMode int
+
+const (
+	// Compact shows only package name and latest tag
+	Compact DisplayMode = iota
+	// Verbose shows all details
+	Verbose
+)
+
+// ShowPackageList displays a list of packages in a table format
+func ShowPackageList(packages []discovery.Package, mode DisplayMode) {
+	if len(packages) == 0 {
+		color.Red("No Go packages found.")
+		return
+	}
+
+	// Create table
+	table := tablewriter.NewWriter(os.Stdout)
+
+	if mode == Verbose {
+		table.Header("#", "Module", "Package", "Go Version", "GitHub", "Latest Tag")
+	} else {
+		table.Header("#", "Package", "Latest Tag")
+	}
+
+	// Add rows
+	for i, pkg := range packages {
+		// Handle empty values
+		goVersion := pkg.GoVersion
+		if goVersion == "" {
+			goVersion = "-"
+		}
+
+		github := pkg.GitHubRepo
+		if github == "" {
+			github = "-"
+		}
+
+		latestTag := pkg.LatestTag
+		if latestTag == "" {
+			latestTag = "(no tags)"
+		}
+
+		if mode == Verbose {
+			table.Append(fmt.Sprintf("%d", i+1), pkg.ModulePath, pkg.PackageName, goVersion, github, latestTag)
+		} else {
+			table.Append(fmt.Sprintf("%d", i+1), pkg.PackageName, latestTag)
+		}
+	}
+
+	table.Render()
+}
+
+// ShowPackageListWithHeader displays a list of packages with a header
+func ShowPackageListWithHeader(packages []discovery.Package, mode DisplayMode, searchPaths []string) {
+	color.Cyan("Discovered %d Go packages:", len(packages))
+	color.White("Search paths: %s", strings.Join(searchPaths, ", "))
+	color.White("")
+
+	ShowPackageList(packages, mode)
+}

pkg/interactive/interactive.go

@@ -142,11 +142,7 @@ func SelectPackage(packages []discovery.Package) (*discovery.Package, error) {
 		return nil, fmt.Errorf("no packages found")
 	}
 
-	color.Cyan("\nAvailable packages:")
-	for i, pkg := range packages {
-		color.White("%d. %s (%s)", i+1, pkg.ModulePath, pkg.PackageName)
-	}
-
+	// No need to display packages again - they're already shown in the table
 	selection, err := selectOption(1, len(packages))
 	if err != nil {
 		return nil, err

pkg/tagutils/tagutils.go

@@ -116,11 +116,16 @@ func ExtractPackageNameFromModule(modulePath string) string {
 
 // ValidateTagFormat validates a tag format string
 func ValidateTagFormat(format string) error {
-	// Check for required placeholders
-	required := []string{"{major}", "{minor}", "{patch}"}
-	for _, placeholder := range required {
-		if !strings.Contains(format, placeholder) {
-			return fmt.Errorf("tag format must contain %s placeholder", placeholder)
+	// Check if format contains {version} (which is valid on its own)
+	if strings.Contains(format, "{version}") {
+		// {version} is valid on its own, no other placeholders required
+	} else {
+		// If not using {version}, check for required individual placeholders
+		required := []string{"{major}", "{minor}", "{patch}"}
+		for _, placeholder := range required {
+			if !strings.Contains(format, placeholder) {
+				return fmt.Errorf("tag format must contain %s placeholder", placeholder)
+			}
 		}
 	}