Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make slonik a dev dependency #1

Open
mmkal opened this issue Apr 26, 2019 · 0 comments · May be fixed by #6
Open

make slonik a dev dependency #1

mmkal opened this issue Apr 26, 2019 · 0 comments · May be fixed by #6
Labels
enhancement New feature or request

Comments

@mmkal
Copy link

mmkal commented Apr 26, 2019

Since slonik is only used for types in this and all the child packages, could it be relegated to devDependencies? The dependency in package.json (16.8.0) isn't the latest version so by using this it's causing multiple copies of slonik to end up in my node_modules.

As a separate suggestion - might it make sense for this and all the other slonik-* packages be moved to https://github.com/gajus/slonik and that repo be made a lerna/yarn monorepo? That way it'd make it easier to apply fixed versioning to packages that do depend on slonik, test, track issues etc.

@gajus gajus added the enhancement New feature or request label Apr 26, 2019
leosuncin added a commit to leosuncin/slonik-interceptor-preset that referenced this issue Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants