Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Move dataset_ids to separate message #96

Open
mbaudis opened this issue May 8, 2017 · 2 comments
Open

Move dataset_ids to separate message #96

mbaudis opened this issue May 8, 2017 · 2 comments
Labels
stalled No plans to implement it in the short term theme:Response Beacon Response Format type:feature

Comments

@mbaudis
Copy link
Member

mbaudis commented May 8, 2017

the current BeaconAlleleResponse message embeds the optional specification of dataset ids. With a foreseeable move to multiple variant and metadata message query types, it seems logical to have the datasets specified outside of the variant queries.
@jrambla
Copy link
Collaborator

jrambla commented May 12, 2017

I agree.
But in the future...
As it is an integral part of the request, I don't clearly see how to do it.
Also, as these are just two "small" parameters, I suggest to go ahead duplicating them in both requests and refine it when we see how and see it fit.

@mcupak
Copy link
Contributor

mcupak commented Jun 13, 2017

What would this look like encoded in proto3?

@juhtornr juhtornr added this to the 0.5 milestone Mar 7, 2018
@juhtornr juhtornr added the theme:Response Beacon Response Format label Mar 15, 2018
@jrambla jrambla removed this from the 0.5 milestone Sep 18, 2018
@jrambla jrambla added the stalled No plans to implement it in the short term label Sep 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
stalled No plans to implement it in the short term theme:Response Beacon Response Format type:feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@juhtornr @mbaudis @mcupak @jrambla